LockD: move global usage counter manipulation from error path
Stanislav Kinsbursky [Wed, 25 Apr 2012 14:23:02 +0000 (18:23 +0400)]
Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

fs/lockd/svc.c

index ad11ea7..53cd69e 100644 (file)
@@ -329,7 +329,7 @@ static struct svc_serv *lockd_create_svc(void)
 int lockd_up(struct net *net)
 {
        struct svc_serv *serv;
-       int             error = 0;
+       int error;
 
        mutex_lock(&nlmsvc_mutex);
 
@@ -370,14 +370,13 @@ int lockd_up(struct net *net)
                goto err_start;
        }
 
+       nlmsvc_users++;
        /*
         * Note: svc_serv structures have an initial use count of 1,
         * so we exit through here on both success and failure.
         */
 err_net:
        svc_destroy(serv);
-       if (!error)
-               nlmsvc_users++;
 err_create:
        mutex_unlock(&nlmsvc_mutex);
        return error;