ipv4: Cap ADVMSS metric in the FIB rather than the routing cache.
David S. Miller [Mon, 18 Jun 2012 02:47:34 +0000 (19:47 -0700)]
It makes no sense to execute this limit test every time we create a
routing cache entry.

We can't simply error out on these things since we've silently
accepted and truncated them forever.

Signed-off-by: David S. Miller <davem@davemloft.net>

net/ipv4/fib_semantics.c
net/ipv4/route.c

index e5b7182..415f823 100644 (file)
@@ -779,9 +779,14 @@ struct fib_info *fib_create_info(struct fib_config *cfg)
                        int type = nla_type(nla);
 
                        if (type) {
+                               u32 val;
+
                                if (type > RTAX_MAX)
                                        goto err_inval;
-                               fi->fib_metrics[type - 1] = nla_get_u32(nla);
+                               val = nla_get_u32(nla);
+                               if (type == RTAX_ADVMSS && val > 65535 - 40)
+                                       val = 65535 - 40;
+                               fi->fib_metrics[type - 1] = val;
                        }
                }
        }
index 41df529..a91f6d3 100644 (file)
@@ -1951,8 +1951,6 @@ static void rt_set_nexthop(struct rtable *rt, const struct flowi4 *fl4,
 
        if (dst_mtu(dst) > IP_MAX_MTU)
                dst_metric_set(dst, RTAX_MTU, IP_MAX_MTU);
-       if (dst_metric_raw(dst, RTAX_ADVMSS) > 65535 - 40)
-               dst_metric_set(dst, RTAX_ADVMSS, 65535 - 40);
 
 #ifdef CONFIG_IP_ROUTE_CLASSID
 #ifdef CONFIG_IP_MULTIPLE_TABLES