]> nv-tegra.nvidia Code Review - linux-3.10.git/commitdiff
MD: raid1 s/sysfs_notify_dirent/sysfs_notify_dirent_safe
authorJonathan Brassow <jbrassow@redhat.com>
Wed, 27 Jul 2011 01:00:36 +0000 (11:00 +1000)
committerNeilBrown <neilb@suse.de>
Wed, 27 Jul 2011 01:00:36 +0000 (11:00 +1000)
If device-mapper creates a RAID1 array that includes devices to
be rebuilt, it will deref a NULL pointer when finished because
sysfs is not used by device-mapper instantiated RAID devices.

Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/raid1.c

index a7e69081187fc864ec217bd5c1a250c2f8d9f6ab..3cbf0ac2aaad3b6bdab9c859d36f44369e027ff7 100644 (file)
@@ -1031,7 +1031,7 @@ static int raid1_spare_active(mddev_t *mddev)
                    && !test_bit(Faulty, &rdev->flags)
                    && !test_and_set_bit(In_sync, &rdev->flags)) {
                        count++;
-                       sysfs_notify_dirent(rdev->sysfs_state);
+                       sysfs_notify_dirent_safe(rdev->sysfs_state);
                }
        }
        spin_lock_irqsave(&conf->device_lock, flags);