x86/PCI: add spinlock held check to 'pcibios_fwaddrmap_lookup()'
Myron Stowe [Fri, 2 Mar 2012 19:45:01 +0000 (12:45 -0700)]
'pcibios_fwaddrmap_lookup()' is used to maintain FW-assigned BIOS BAR
values for reinstatement when normal resource assignment attempts
fail and must be called with the 'pcibios_fwaddrmap_lock' spinlock
held.

This patch adds a WARN_ON notification if the spinlock is not currently
held by the caller.

Signed-off-by: Myron Stowe <myron.stowe@redhat.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

arch/x86/pci/i386.c

index 33e6a0b..831971e 100644 (file)
@@ -57,6 +57,8 @@ static struct pcibios_fwaddrmap *pcibios_fwaddrmap_lookup(struct pci_dev *dev)
 {
        struct pcibios_fwaddrmap *map;
 
+       WARN_ON(!spin_is_locked(&pcibios_fwaddrmap_lock));
+
        list_for_each_entry(map, &pcibios_fwaddrmappings, list)
                if (map->dev == dev)
                        return map;