[ARM] shark: avoid polluting the kernel's namespace
Russell King [Fri, 28 Nov 2008 16:13:44 +0000 (16:13 +0000)]
Avoid unnecessarily pollution of the kernel's namespace by avoiding
mach/hardware.h in mach/io.h.  Include this header file where necessary.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

arch/arm/mach-shark/core.c
arch/arm/mach-shark/include/mach/hardware.h
arch/arm/mach-shark/include/mach/io.h

index a9400d9..a23fd3d 100644 (file)
@@ -16,6 +16,8 @@
 #include <asm/leds.h>
 #include <asm/param.h>
 
+#include <mach/hardware.h>
+
 #include <asm/mach/map.h>
 #include <asm/mach/arch.h>
 #include <asm/mach/time.h>
index cb0ee29..01bf760 100644 (file)
@@ -28,8 +28,6 @@
 #define ROMCARD_SIZE           0x08000000
 #define ROMCARD_START          0x10000000
 
-#define PCIO_BASE              0xe0000000
-
 
 /* defines for the Framebuffer */
 #define FB_START               0x06000000
index 751ab41..c5cee82 100644 (file)
 #ifndef __ASM_ARM_ARCH_IO_H
 #define __ASM_ARM_ARCH_IO_H
 
-#include <mach/hardware.h>
+#define PCIO_BASE      0xe0000000
+#define IO_SPACE_LIMIT 0xffffffff
 
-#define IO_SPACE_LIMIT 0xffffffff
-
-/*
- * We use two different types of addressing - PC style addresses, and ARM
- * addresses.  PC style accesses the PC hardware with the normal PC IO
- * addresses, eg 0x3f8 for serial#1.  ARM addresses are 0x80000000+
- * and are translated to the start of IO.
- */
-#define __PORT_PCIO(x) (!((x) & 0x80000000))
-
-#define __io(a)                 ((void __iomem *)(PCIO_BASE + (a)))
-
-
-static inline unsigned int __ioaddr (unsigned int port)                        \
-{                                                                              \
-       if (__PORT_PCIO(port))                                                  \
-               return (unsigned int)(PCIO_BASE + (port));                      \
-       else                                                                    \
-               return (unsigned int)(IO_BASE + (port));                        \
-}
-
-#define __mem_pci(addr) (addr)
+#define __io(a)                ((void __iomem *)(PCIO_BASE + (a)))
+#define __mem_pci(addr)        (addr)
 
 #endif