drivers: Kill now superfluous ->last_rx stores
Eric Dumazet [Mon, 31 Aug 2009 06:34:50 +0000 (06:34 +0000)]
The generic packet receive code takes care of setting
netdev->last_rx when necessary, for the sake of the
bonding ARP monitor.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Neil Horman <nhorman@txudriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

25 files changed:
drivers/firewire/net.c
drivers/ieee1394/eth1394.c
drivers/infiniband/hw/amso1100/c2.c
drivers/infiniband/hw/nes/nes_hw.c
drivers/infiniband/ulp/ipoib/ipoib_cm.c
drivers/infiniband/ulp/ipoib/ipoib_ib.c
drivers/misc/sgi-xp/xpnet.c
drivers/net/arm/ks8695net.c
drivers/net/arm/w90p910_ether.c
drivers/net/atl1c/atl1c_main.c
drivers/net/benet/be_main.c
drivers/net/can/dev.c
drivers/net/can/sja1000/sja1000.c
drivers/net/davinci_emac.c
drivers/net/ethoc.c
drivers/net/igbvf/netdev.c
drivers/net/smsc911x.c
drivers/net/smsc9420.c
drivers/net/vxge/vxge-main.c
drivers/net/wireless/b43legacy/xmit.c
drivers/net/xilinx_emaclite.c
drivers/s390/net/ctcm_main.c
drivers/s390/net/netiucv.c
drivers/s390/net/qeth_l2_main.c
drivers/s390/net/qeth_l3_main.c

index 84edc8b..cbaf420 100644 (file)
@@ -663,8 +663,6 @@ static int fwnet_finish_incoming_packet(struct net_device *net,
        if (netif_queue_stopped(net))
                netif_wake_queue(net);
 
-       net->last_rx = jiffies;
-
        return 0;
 }
 
index 3a62c4c..a4e9dcb 100644 (file)
@@ -1301,7 +1301,6 @@ static void ether1394_iso(struct hpsb_iso *iso)
 
        hpsb_iso_recv_release_packets(iso, i);
 
-       dev->last_rx = jiffies;
 }
 
 /******************************************
index 0cfbb6d..8c5d284 100644 (file)
@@ -530,7 +530,6 @@ static void c2_rx_interrupt(struct net_device *netdev)
 
                netif_rx(skb);
 
-               netdev->last_rx = jiffies;
                netdev->stats.rx_packets++;
                netdev->stats.rx_bytes += buflen;
        }
index 4a84d02..97d4c2a 100644 (file)
@@ -2741,7 +2741,7 @@ void nes_nic_ce_handler(struct nes_device *nesdev, struct nes_hw_nic_cq *cq)
                                }
 
 skip_rx_indicate0:
-                               nesvnic->netdev->last_rx = jiffies;
+                               ;
                                /* nesvnic->netstats.rx_packets++; */
                                /* nesvnic->netstats.rx_bytes += rx_pkt_size; */
                        }
index 181b1f3..986f07f 100644 (file)
@@ -663,7 +663,6 @@ copied:
        skb_reset_mac_header(skb);
        skb_pull(skb, IPOIB_ENCAP_LEN);
 
-       dev->last_rx = jiffies;
        ++dev->stats.rx_packets;
        dev->stats.rx_bytes += skb->len;
 
index e7e5adf..c9dcb20 100644 (file)
@@ -277,7 +277,6 @@ static void ipoib_ib_handle_rx_wc(struct net_device *dev, struct ib_wc *wc)
        skb_reset_mac_header(skb);
        skb_pull(skb, IPOIB_ENCAP_LEN);
 
-       dev->last_rx = jiffies;
        ++dev->stats.rx_packets;
        dev->stats.rx_bytes += skb->len;
 
index 212da9a..16f0abd 100644 (file)
@@ -240,7 +240,6 @@ xpnet_receive(short partid, int channel, struct xpnet_message *msg)
                (void *)skb->head, (void *)skb->data, skb_tail_pointer(skb),
                skb_end_pointer(skb), skb->len);
 
-       xpnet_device->last_rx = jiffies;
        xpnet_device->stats.rx_packets++;
        xpnet_device->stats.rx_bytes += skb->len + ETH_HLEN;
 
index 4f702d5..2a7b774 100644 (file)
@@ -467,7 +467,6 @@ ks8695_rx_irq(int irq, void *dev_id)
                        netif_rx(skb);
 
                        /* Record stats */
-                       ndev->last_rx = jiffies;
                        ndev->stats.rx_packets++;
                        ndev->stats.rx_bytes += pktlen;
                        goto rx_finished;
index 3a0948f..25e2627 100644 (file)
@@ -777,7 +777,6 @@ static void netdev_rx(struct net_device *dev)
 
                rxbd = &ether->rdesc->desclist[ether->cur_rx];
 
-               dev->last_rx = jiffies;
        } while (1);
 }
 
index bf7cc83..e46bf92 100644 (file)
@@ -1740,7 +1740,6 @@ rrs_checked:
                } else
                        netif_receive_skb(skb);
 
-               netdev->last_rx = jiffies;
                (*work_done)++;
                count++;
        }
index e19fe1d..bac85f9 100644 (file)
@@ -775,8 +775,6 @@ static void be_rx_compl_process(struct be_adapter *adapter,
                netif_receive_skb(skb);
        }
 
-       adapter->netdev->last_rx = jiffies;
-
        return;
 }
 
index e1a4f82..1d29082 100644 (file)
@@ -357,7 +357,6 @@ void can_restart(unsigned long data)
 
        netif_rx(skb);
 
-       dev->last_rx = jiffies;
        stats->rx_packets++;
        stats->rx_bytes += cf->can_dlc;
 
index 9ce3dda..fd7fa71 100644 (file)
@@ -340,7 +340,6 @@ static void sja1000_rx(struct net_device *dev)
 
        netif_rx(skb);
 
-       dev->last_rx = jiffies;
        stats->rx_packets++;
        stats->rx_bytes += dlc;
 }
@@ -455,7 +454,6 @@ static int sja1000_err(struct net_device *dev, uint8_t isrc, uint8_t status)
 
        netif_rx(skb);
 
-       dev->last_rx = jiffies;
        stats->rx_packets++;
        stats->rx_bytes += cf->can_dlc;
 
index 5e6652b..d465eaa 100644 (file)
@@ -1920,7 +1920,6 @@ static int emac_net_rx_cb(struct emac_priv *priv,
        skb_put(p_skb, net_pkt_list->pkt_length);
        EMAC_CACHE_INVALIDATE((unsigned long)p_skb->data, p_skb->len);
        p_skb->protocol = eth_type_trans(p_skb, priv->ndev);
-       p_skb->dev->last_rx = jiffies;
        netif_receive_skb(p_skb);
        priv->net_dev_stats.rx_bytes += net_pkt_list->pkt_length;
        priv->net_dev_stats.rx_packets++;
index b871aef..b7311bc 100644 (file)
@@ -404,7 +404,6 @@ static int ethoc_rx(struct net_device *dev, int limit)
                                void *src = priv->membase + bd.addr;
                                memcpy_fromio(skb_put(skb, size), src, size);
                                skb->protocol = eth_type_trans(skb, dev);
-                               dev->last_rx = jiffies;
                                priv->stats.rx_packets++;
                                priv->stats.rx_bytes += size;
                                netif_receive_skb(skb);
index dadb782..91024a3 100644 (file)
@@ -96,8 +96,6 @@ static void igbvf_receive_skb(struct igbvf_adapter *adapter,
                                         E1000_RXD_SPC_VLAN_MASK);
        else
                netif_receive_skb(skb);
-
-       netdev->last_rx = jiffies;
 }
 
 static inline void igbvf_rx_checksum_adv(struct igbvf_adapter *adapter,
@@ -342,8 +340,6 @@ send_up:
                igbvf_receive_skb(adapter, netdev, skb, staterr,
                                  rx_desc->wb.upper.vlan);
 
-               netdev->last_rx = jiffies;
-
 next_desc:
                rx_desc->wb.upper.status_error = 0;
 
index c266785..ccdd196 100644 (file)
@@ -1047,7 +1047,6 @@ static int smsc911x_poll(struct napi_struct *napi, int budget)
                /* Update counters */
                dev->stats.rx_packets++;
                dev->stats.rx_bytes += (pktlength - 4);
-               dev->last_rx = jiffies;
        }
 
        /* Return total received packets */
index 514311d..b4909a2 100644 (file)
@@ -817,7 +817,6 @@ static void smsc9420_rx_handoff(struct smsc9420_pdata *pd, const int index,
        skb->protocol = eth_type_trans(skb, dev);
 
        netif_receive_skb(skb);
-       dev->last_rx = jiffies;
 }
 
 static int smsc9420_alloc_rx_buffer(struct smsc9420_pdata *pd, int index)
index 41dccba..b378037 100644 (file)
@@ -588,8 +588,6 @@ vxge_rx_1b_compl(struct __vxge_hw_ring *ringh, void *dtr,
        if (first_dtr)
                vxge_hw_ring_rxd_post_post_wmb(ringh, first_dtr);
 
-       dev->last_rx = jiffies;
-
        vxge_debug_entryexit(VXGE_TRACE,
                                "%s:%d  Exiting...",
                                __func__, __LINE__);
index f79cee8..103f3c9 100644 (file)
@@ -590,7 +590,6 @@ void b43legacy_rx(struct b43legacy_wldev *dev,
                       chanstat);
        }
 
-       dev->stats.last_rx = jiffies;
        memcpy(IEEE80211_SKB_RXCB(skb), &status, sizeof(status));
        ieee80211_rx_irqsafe(dev->wl->hw, skb);
 
index 7e05b40..dc22782 100644 (file)
@@ -587,7 +587,6 @@ static void xemaclite_rx_handler(struct net_device *dev)
 
        dev->stats.rx_packets++;
        dev->stats.rx_bytes += len;
-       dev->last_rx = jiffies;
 
        netif_rx(skb);          /* Send the packet upstream */
 }
index 38b5079..c5b8387 100644 (file)
@@ -164,7 +164,6 @@ void ctcm_unpack_skb(struct channel *ch, struct sk_buff *pskb)
                priv->stats.rx_packets++;
                priv->stats.rx_bytes += skblen;
                netif_rx_ni(skb);
-               dev->last_rx = jiffies;
                if (len > 0) {
                        skb_pull(pskb, header->length);
                        if (skb_tailroom(pskb) < LL_HEADER_LENGTH) {
index bb1183a..271c4a8 100644 (file)
@@ -676,7 +676,6 @@ static void netiucv_unpack_skb(struct iucv_connection *conn,
                 * we must use netif_rx_ni() instead of netif_rx()
                 */
                netif_rx_ni(skb);
-               dev->last_rx = jiffies;
                skb_pull(pskb, header->next);
                skb_put(pskb, NETIUCV_HDRLEN);
        }
index 94b1611..f4f3ca1 100644 (file)
@@ -449,7 +449,6 @@ static void qeth_l2_process_inbound_buffer(struct qeth_card *card,
                        QETH_DBF_HEX(CTRL, 3, hdr, QETH_DBF_CTRL_LEN);
                        continue;
                }
-               card->dev->last_rx = jiffies;
                card->stats.rx_packets++;
                card->stats.rx_bytes += len;
        }
index 115b4a0..073b6d3 100644 (file)
@@ -1987,7 +1987,6 @@ static void qeth_l3_process_inbound_buffer(struct qeth_card *card,
                        continue;
                }
 
-               card->dev->last_rx = jiffies;
                card->stats.rx_packets++;
                card->stats.rx_bytes += len;
        }