USB: serial: fix up bug with missing {}
Greg Kroah-Hartman [Wed, 19 Sep 2012 07:15:21 +0000 (08:15 +0100)]
As reported by Fengguang:

FYI, coccinelle warns about

drivers/usb/serial/usb-serial.c:1415:3-51: code aligned with following code on line 1416

vim +1415 drivers/usb/serial/usb-serial.c

  1412          /* we only set the reset_resume field if the serial_driver has one */
  1413          for (sd = serial_drivers; *sd; ++sd) {
  1414                  if ((*sd)->reset_resume)
> 1415                          udriver->reset_resume = usb_serial_reset_resume;
> 1416                          break;
  1417          }

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: stable <stable@vger.kernel.org> [3.5]
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/usb/serial/usb-serial.c

index 011c520..483919b 100644 (file)
@@ -1404,9 +1404,10 @@ int usb_serial_register_drivers(struct usb_serial_driver *const serial_drivers[]
 
        /* we only set the reset_resume field if the serial_driver has one */
        for (sd = serial_drivers; *sd; ++sd) {
-               if ((*sd)->reset_resume)
+               if ((*sd)->reset_resume) {
                        udriver->reset_resume = usb_serial_reset_resume;
                        break;
+               }
        }
 
        rc = usb_register(udriver);