]> nv-tegra.nvidia Code Review - linux-3.10.git/commitdiff
ALSA: sb8 - Fix a return code in the error path
authorTakashi Iwai <tiwai@suse.de>
Thu, 11 Dec 2008 11:12:06 +0000 (12:12 +0100)
committerTakashi Iwai <tiwai@suse.de>
Thu, 11 Dec 2008 11:12:06 +0000 (12:12 +0100)
Fixed a compile warning below:
  sound/isa/sb/sb8.c: In function ‘snd_sb8_probe’:
  sound/isa/sb/sb8.c:104: warning: ‘err’ may be used uninitialized in this function
by setting the return value correctly.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/isa/sb/sb8.c

index 667eccc676a40a8898f887ef21288cefa717624f..ea06877be4b135fb8256de12ebe416dc9df46901 100644 (file)
@@ -140,8 +140,10 @@ static int __devinit snd_sb8_probe(struct device *pdev, unsigned int dev)
                                break;
                        }
                }
-               if (i >= ARRAY_SIZE(possible_ports))
+               if (i >= ARRAY_SIZE(possible_ports)) {
+                       err = -EINVAL;
                        goto _err;
+               }
        }
        acard->chip = chip;