cifs: Use BUILD_BUG_ON to validate uids and gids are the same size
Eric W. Biederman [Wed, 6 Feb 2013 08:10:23 +0000 (00:10 -0800)]
The assumption that sizeof(uid_t) is the same as sizeof(gid_t) is
completely reasonable but since we can verify the condition at
compile time.

Cc: Steve French <smfrench@gmail.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

fs/cifs/cifsacl.c

index 5cbd00e..2e811f4 100644 (file)
@@ -297,6 +297,7 @@ sid_to_id(struct cifs_sb_info *cifs_sb, struct cifs_sid *psid,
         * probably a safe assumption but might be better to check based on
         * sidtype.
         */
+       BUILD_BUG_ON(sizeof(uid_t) != sizeof(gid_t));
        if (sidkey->datalen != sizeof(uid_t)) {
                rc = -EIO;
                cFYI(1, "%s: Downcall contained malformed key "