Yama: replace capable() with ns_capable()
Kees Cook [Mon, 14 May 2012 17:19:28 +0000 (10:19 -0700)]
When checking capabilities, the question we want to be asking is "does
current() have the capability in the child's namespace?"

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: James Morris <james.l.morris@oracle.com>

security/yama/yama_lsm.c

index c852f74..83554ee 100644 (file)
@@ -264,11 +264,11 @@ static int yama_ptrace_access_check(struct task_struct *child,
                case YAMA_SCOPE_RELATIONAL:
                        if (!task_is_descendant(current, child) &&
                            !ptracer_exception_found(current, child) &&
-                           !capable(CAP_SYS_PTRACE))
+                           !ns_capable(task_user_ns(child), CAP_SYS_PTRACE))
                                rc = -EPERM;
                        break;
                case YAMA_SCOPE_CAPABILITY:
-                       if (!capable(CAP_SYS_PTRACE))
+                       if (!ns_capable(task_user_ns(child), CAP_SYS_PTRACE))
                                rc = -EPERM;
                        break;
                case YAMA_SCOPE_NO_ATTACH: