]> nv-tegra.nvidia Code Review - linux-3.10.git/commitdiff
rtc: rtc-pcf8523: use devm_rtc_device_register()
authorJingoo Han <jg1.han@samsung.com>
Mon, 29 Apr 2013 23:19:11 +0000 (16:19 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 30 Apr 2013 01:28:26 +0000 (18:28 -0700)
devm_rtc_device_register() is device managed and makes cleanup
paths simpler.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rtc/rtc-pcf8523.c

index 889e3160e70138277f651dc0ae401cf891d6005f..305c9515e5bb4b578b74a2b0ff44bcbbce18d4e6 100644 (file)
@@ -307,7 +307,7 @@ static int pcf8523_probe(struct i2c_client *client,
        if (err < 0)
                return err;
 
-       pcf->rtc = rtc_device_register(DRIVER_NAME, &client->dev,
+       pcf->rtc = devm_rtc_device_register(&client->dev, DRIVER_NAME,
                                       &pcf8523_rtc_ops, THIS_MODULE);
        if (IS_ERR(pcf->rtc))
                return PTR_ERR(pcf->rtc);
@@ -319,10 +319,6 @@ static int pcf8523_probe(struct i2c_client *client,
 
 static int pcf8523_remove(struct i2c_client *client)
 {
-       struct pcf8523 *pcf = i2c_get_clientdata(client);
-
-       rtc_device_unregister(pcf->rtc);
-
        return 0;
 }