EISA: Initialize device before its resources
Bjorn Helgaas [Mon, 15 Apr 2013 20:34:02 +0000 (14:34 -0600)]
Move eisa_init_device() before eisa_request_resources() so the device
name is set before we set up its resources.  That way we can print
better messages.

Previously edev->res[i].name was set to NULL in eisa_request_resources(),
then filled in by eisa_init_device().  Now it is filled in by
eisa_init_device() first, and we don't want to clear it out later in
eisa_request_resources().

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

drivers/eisa/eisa-bus.c

index bf30dcb..d0c50b4 100644 (file)
@@ -275,13 +275,11 @@ static int __init eisa_request_resources(struct eisa_root_device *root,
                }
                
                if (slot) {
-                       edev->res[i].name  = NULL;
                        edev->res[i].start = SLOT_ADDRESS(root, slot)
                                             + (i * 0x400);
                        edev->res[i].end   = edev->res[i].start + 0xff;
                        edev->res[i].flags = IORESOURCE_IO;
                } else {
-                       edev->res[i].name  = NULL;
                        edev->res[i].start = SLOT_ADDRESS(root, slot)
                                             + EISA_VENDOR_ID_OFFSET;
                        edev->res[i].end   = edev->res[i].start + 3;
@@ -327,20 +325,19 @@ static int __init eisa_probe(struct eisa_root_device *root)
                return -ENOMEM;
        }
                
-       if (eisa_request_resources(root, edev, 0)) {
-               dev_warn(root->dev,
-                        "EISA: Cannot allocate resource for mainboard\n");
+       if (eisa_init_device(root, edev, 0)) {
                kfree(edev);
                if (!root->force_probe)
-                       return -EBUSY;
+                       return -ENODEV;
                goto force_probe;
        }
 
-       if (eisa_init_device(root, edev, 0)) {
-               eisa_release_resources(edev);
+       if (eisa_request_resources(root, edev, 0)) {
+               dev_warn(root->dev,
+                        "EISA: Cannot allocate resource for mainboard\n");
                kfree(edev);
                if (!root->force_probe)
-                       return -ENODEV;
+                       return -EBUSY;
                goto force_probe;
        }
 
@@ -363,16 +360,15 @@ static int __init eisa_probe(struct eisa_root_device *root)
                        continue;
                }
 
-               if (eisa_request_resources(root, edev, i)) {
-                       dev_warn(root->dev,
-                                "Cannot allocate resource for EISA slot %d\n",
-                                i);
+               if (eisa_init_device(root, edev, i)) {
                        kfree(edev);
                        continue;
                }
 
-               if (eisa_init_device(root, edev, i)) {
-                       eisa_release_resources(edev);
+               if (eisa_request_resources(root, edev, i)) {
+                       dev_warn(root->dev,
+                                "Cannot allocate resource for EISA slot %d\n",
+                                i);
                        kfree(edev);
                        continue;
                }