net: remove redundant check for timer pending state before del_timer
Ying Xue [Sun, 3 Feb 2013 20:32:57 +0000 (20:32 +0000)]
As in del_timer() there has already placed a timer_pending() function
to check whether the timer to be deleted is pending or not, it's
unnecessary to check timer pending state again before del_timer() is
called.

Signed-off-by: Ying Xue <ying.xue@windriver.com>
Cc: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

net/bluetooth/rfcomm/core.c
net/bridge/netfilter/ebt_ulog.c
net/core/sock.c
net/ipv4/netfilter/ipt_ULOG.c
net/irda/af_irda.c
net/netfilter/ipvs/ip_vs_conn.c
net/sctp/associola.c
net/sctp/input.c
net/sctp/outqueue.c
net/sctp/sm_sideeffect.c
net/sctp/transport.c

index 201fdf7..b23e271 100644 (file)
@@ -257,7 +257,7 @@ static void rfcomm_session_clear_timer(struct rfcomm_session *s)
 {
        BT_DBG("session %p state %ld", s, s->state);
 
-       if (timer_pending(&s->timer) && del_timer(&s->timer))
+       if (del_timer(&s->timer))
                rfcomm_session_put(s);
 }
 
@@ -285,7 +285,7 @@ static void rfcomm_dlc_clear_timer(struct rfcomm_dlc *d)
 {
        BT_DBG("dlc %p state %ld", d, d->state);
 
-       if (timer_pending(&d->timer) && del_timer(&d->timer))
+       if (del_timer(&d->timer))
                rfcomm_dlc_put(d);
 }
 
index 3476ec4..3bf43f7 100644 (file)
@@ -70,8 +70,7 @@ static void ulog_send(unsigned int nlgroup)
 {
        ebt_ulog_buff_t *ub = &ulog_buffers[nlgroup];
 
-       if (timer_pending(&ub->timer))
-               del_timer(&ub->timer);
+       del_timer(&ub->timer);
 
        if (!ub->skb)
                return;
@@ -319,8 +318,7 @@ static void __exit ebt_ulog_fini(void)
        xt_unregister_target(&ebt_ulog_tg_reg);
        for (i = 0; i < EBT_ULOG_MAXNLGROUPS; i++) {
                ub = &ulog_buffers[i];
-               if (timer_pending(&ub->timer))
-                       del_timer(&ub->timer);
+               del_timer(&ub->timer);
                spin_lock_bh(&ub->lock);
                if (ub->skb) {
                        kfree_skb(ub->skb);
index 235fb89..f1e14e2 100644 (file)
@@ -2230,7 +2230,7 @@ EXPORT_SYMBOL(sk_reset_timer);
 
 void sk_stop_timer(struct sock *sk, struct timer_list* timer)
 {
-       if (timer_pending(timer) && del_timer(timer))
+       if (del_timer(timer))
                __sock_put(sk);
 }
 EXPORT_SYMBOL(sk_stop_timer);
index b5ef3cb..7d168dc 100644 (file)
@@ -88,10 +88,8 @@ static void ulog_send(unsigned int nlgroupnum)
 {
        ulog_buff_t *ub = &ulog_buffers[nlgroupnum];
 
-       if (timer_pending(&ub->timer)) {
-               pr_debug("ulog_send: timer was pending, deleting\n");
-               del_timer(&ub->timer);
-       }
+       pr_debug("ulog_send: timer is deleting\n");
+       del_timer(&ub->timer);
 
        if (!ub->skb) {
                pr_debug("ulog_send: nothing to send\n");
@@ -426,10 +424,8 @@ static void __exit ulog_tg_exit(void)
        /* remove pending timers and free allocated skb's */
        for (i = 0; i < ULOG_MAXNLGROUPS; i++) {
                ub = &ulog_buffers[i];
-               if (timer_pending(&ub->timer)) {
-                       pr_debug("timer was pending, deleting\n");
-                       del_timer(&ub->timer);
-               }
+               pr_debug("timer is deleting\n");
+               del_timer(&ub->timer);
 
                if (ub->skb) {
                        kfree_skb(ub->skb);
index b833677..d07e3a6 100644 (file)
@@ -2567,8 +2567,7 @@ bed:
                                                   err);
 
                        /* If watchdog is still activated, kill it! */
-                       if(timer_pending(&(self->watchdog)))
-                               del_timer(&(self->watchdog));
+                       del_timer(&(self->watchdog));
 
                        IRDA_DEBUG(1, "%s(), ...waking up !\n", __func__);
 
index 30e764a..68e368a 100644 (file)
@@ -796,8 +796,7 @@ static void ip_vs_conn_expire(unsigned long data)
         */
        if (likely(atomic_read(&cp->refcnt) == 1)) {
                /* delete the timer if it is activated by other users */
-               if (timer_pending(&cp->timer))
-                       del_timer(&cp->timer);
+               del_timer(&cp->timer);
 
                /* does anybody control me? */
                if (cp->control)
index b45ed1f..2f95f5a 100644 (file)
@@ -434,8 +434,7 @@ void sctp_association_free(struct sctp_association *asoc)
         * on our state.
         */
        for (i = SCTP_EVENT_TIMEOUT_NONE; i < SCTP_NUM_TIMEOUT_TYPES; ++i) {
-               if (timer_pending(&asoc->timers[i]) &&
-                   del_timer(&asoc->timers[i]))
+               if (del_timer(&asoc->timers[i]))
                        sctp_association_put(asoc);
        }
 
@@ -1497,7 +1496,7 @@ void sctp_assoc_rwnd_increase(struct sctp_association *asoc, unsigned int len)
 
                /* Stop the SACK timer.  */
                timer = &asoc->timers[SCTP_EVENT_TIMEOUT_SACK];
-               if (timer_pending(timer) && del_timer(timer))
+               if (del_timer(timer))
                        sctp_association_put(asoc);
        }
 }
index 8bd3c27..965bbbb 100644 (file)
@@ -468,8 +468,7 @@ void sctp_icmp_proto_unreachable(struct sock *sk,
        } else {
                struct net *net = sock_net(sk);
 
-               if (timer_pending(&t->proto_unreach_timer) &&
-                   del_timer(&t->proto_unreach_timer))
+               if (del_timer(&t->proto_unreach_timer))
                        sctp_association_put(asoc);
 
                sctp_do_sm(net, SCTP_EVENT_T_OTHER,
index 9bcdbd0..01dca75 100644 (file)
@@ -1700,10 +1700,8 @@ static void sctp_check_transmitted(struct sctp_outq *q,
                 * address.
                 */
                if (!transport->flight_size) {
-                       if (timer_pending(&transport->T3_rtx_timer) &&
-                           del_timer(&transport->T3_rtx_timer)) {
+                       if (del_timer(&transport->T3_rtx_timer))
                                sctp_transport_put(transport);
-                       }
                } else if (restart_timer) {
                        if (!mod_timer(&transport->T3_rtx_timer,
                                       jiffies + transport->rto))
index c957775..8aab894 100644 (file)
@@ -674,10 +674,8 @@ static void sctp_cmd_t3_rtx_timers_stop(sctp_cmd_seq_t *cmds,
 
        list_for_each_entry(t, &asoc->peer.transport_addr_list,
                        transports) {
-               if (timer_pending(&t->T3_rtx_timer) &&
-                   del_timer(&t->T3_rtx_timer)) {
+               if (del_timer(&t->T3_rtx_timer))
                        sctp_transport_put(t);
-               }
        }
 }
 
@@ -1517,7 +1515,7 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
 
                case SCTP_CMD_TIMER_STOP:
                        timer = &asoc->timers[cmd->obj.to];
-                       if (timer_pending(timer) && del_timer(timer))
+                       if (del_timer(timer))
                                sctp_association_put(asoc);
                        break;
 
index ca5331c..fafd2a4 100644 (file)
@@ -151,13 +151,11 @@ void sctp_transport_free(struct sctp_transport *transport)
         * structure hang around in memory since we know
         * the tranport is going away.
         */
-       if (timer_pending(&transport->T3_rtx_timer) &&
-           del_timer(&transport->T3_rtx_timer))
+       if (del_timer(&transport->T3_rtx_timer))
                sctp_transport_put(transport);
 
        /* Delete the ICMP proto unreachable timer if it's active. */
-       if (timer_pending(&transport->proto_unreach_timer) &&
-           del_timer(&transport->proto_unreach_timer))
+       if (del_timer(&transport->proto_unreach_timer))
                sctp_association_put(transport->asoc);
 
        sctp_transport_put(transport);
@@ -655,10 +653,9 @@ void sctp_transport_reset(struct sctp_transport *t)
 void sctp_transport_immediate_rtx(struct sctp_transport *t)
 {
        /* Stop pending T3_rtx_timer */
-       if (timer_pending(&t->T3_rtx_timer)) {
-               (void)del_timer(&t->T3_rtx_timer);
+       if (del_timer(&t->T3_rtx_timer))
                sctp_transport_put(t);
-       }
+
        sctp_retransmit(&t->asoc->outqueue, t, SCTP_RTXR_T3_RTX);
        if (!timer_pending(&t->T3_rtx_timer)) {
                if (!mod_timer(&t->T3_rtx_timer, jiffies + t->rto))