perf session: Register the idle thread in perf_session__process_events
Arnaldo Carvalho de Melo [Sun, 13 Dec 2009 21:50:26 +0000 (19:50 -0200)]
No need for all tools to register it and then immediately call
perf_session__process_events.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1260741029-4430-3-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

tools/perf/builtin-annotate.c
tools/perf/builtin-kmem.c
tools/perf/builtin-report.c
tools/perf/builtin-sched.c
tools/perf/builtin-trace.c
tools/perf/util/data_map.c
tools/perf/util/thread.c
tools/perf/util/thread.h

index 43e3bb3..93d765a 100644 (file)
@@ -464,14 +464,11 @@ static int __cmd_annotate(void)
 {
        struct perf_session *session = perf_session__new(input_name, O_RDONLY,
                                                         force);
-       struct thread *idle;
        int ret;
 
        if (session == NULL)
                return -ENOMEM;
 
-       idle = register_idle_thread();
-
        ret = perf_session__process_events(session, &event_ops, 0,
                                           &event__cwdlen, &event__cwd);
        if (ret)
index 6f74bd8..37a8499 100644 (file)
@@ -372,7 +372,6 @@ static int read_events(void)
        if (session == NULL)
                return -ENOMEM;
 
-       register_idle_thread();
        err = perf_session__process_events(session, &event_ops, 0,
                                           &event__cwdlen, &event__cwd);
        perf_session__delete(session);
index c203eaf..4b37ac4 100644 (file)
@@ -761,7 +761,6 @@ static struct perf_event_ops event_ops = {
 
 static int __cmd_report(void)
 {
-       struct thread *idle;
        int ret;
        struct perf_session *session;
 
@@ -769,9 +768,6 @@ static int __cmd_report(void)
        if (session == NULL)
                return -ENOMEM;
 
-       idle = register_idle_thread();
-       thread__comm_adjust(idle);
-
        if (show_threads)
                perf_read_values_init(&show_threads_values);
 
index b5b4472..847ed51 100644 (file)
@@ -1670,8 +1670,6 @@ static int read_events(void)
        if (session == NULL)
                return -ENOMEM;
 
-       register_idle_thread();
-
        err = perf_session__process_events(session, &event_ops, 0,
                                           &event__cwdlen, &event__cwd);
        perf_session__delete(session);
index c404dec..40cb896 100644 (file)
@@ -125,7 +125,6 @@ static struct perf_event_ops event_ops = {
 
 static int __cmd_trace(struct perf_session *session)
 {
-       register_idle_thread();
        return perf_session__process_events(session, &event_ops, 0,
                                            &event__cwdlen, &event__cwd);
 }
index ba5bcfa..36e3bfe 100644 (file)
@@ -1,6 +1,7 @@
 #include "symbol.h"
 #include "util.h"
 #include "debug.h"
+#include "thread.h"
 #include "session.h"
 
 static unsigned long   mmap_window = 32;
@@ -127,6 +128,18 @@ out:
        return err;
 }
 
+static struct thread *perf_session__register_idle_thread(struct perf_session *self __used)
+{
+       struct thread *thread = threads__findnew(0);
+
+       if (!thread || thread__set_comm(thread, "swapper")) {
+               pr_err("problem inserting idle task.\n");
+               thread = NULL;
+       }
+
+       return thread;
+}
+
 int perf_session__process_events(struct perf_session *self,
                                 struct perf_event_ops *ops,
                                 int full_paths, int *cwdlen, char **cwd)
@@ -140,6 +153,9 @@ int perf_session__process_events(struct perf_session *self,
        uint32_t size;
        char *buf;
 
+       if (perf_session__register_idle_thread(self) == NULL)
+               return -ENOMEM;
+
        perf_event_ops__fill_defaults(ops);
 
        page_size = getpagesize();
index b68a00e..5c0ab14 100644 (file)
@@ -161,18 +161,6 @@ struct thread *threads__findnew(pid_t pid)
        return th;
 }
 
-struct thread *register_idle_thread(void)
-{
-       struct thread *thread = threads__findnew(0);
-
-       if (!thread || thread__set_comm(thread, "swapper")) {
-               fprintf(stderr, "problem inserting idle task.\n");
-               exit(-1);
-       }
-
-       return thread;
-}
-
 static void map_groups__remove_overlappings(struct map_groups *self,
                                            struct map *map)
 {
index 1751802..2e35e1f 100644 (file)
@@ -24,7 +24,6 @@ void map_groups__init(struct map_groups *self);
 int thread__set_comm(struct thread *self, const char *comm);
 int thread__comm_len(struct thread *self);
 struct thread *threads__findnew(pid_t pid);
-struct thread *register_idle_thread(void);
 void thread__insert_map(struct thread *self, struct map *map);
 int thread__fork(struct thread *self, struct thread *parent);
 size_t map_groups__fprintf_maps(struct map_groups *self, FILE *fp);