Remove unnecessary check for NULL in password parser
Sachin Prabhu [Wed, 28 Mar 2012 17:07:08 +0000 (18:07 +0100)]
The password parser has an unnecessary check for a NULL value which
triggers warnings in source checking tools. The code contains artifacts
from the old parsing code which are no longer required.

Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

fs/cifs/connect.c

index 302a15c..0511fdb 100644 (file)
@@ -1565,8 +1565,7 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
 
                        /* Obtain the value string */
                        value = strchr(data, '=');
-                       if (value != NULL)
-                               *value++ = '\0';
+                       value++;
 
                        /* Set tmp_end to end of the string */
                        tmp_end = (char *) value + strlen(value);