async: initialise list heads to fix crash
authorJames Hogan <james.hogan@imgtec.com>
Fri, 25 Jan 2013 10:13:59 +0000 (10:13 +0000)
committerTejun Heo <tj@kernel.org>
Fri, 25 Jan 2013 17:14:48 +0000 (09:14 -0800)
commita0327ff0eda915be623658babacef706099c11a8
tree4787aedc2877b41e1df066f510b828574527163c
parent9fdb04cdc5566d6ba68283a0bebe49667ca0b0e8
async: initialise list heads to fix crash

9fdb04cdc55 ("async: replace list of active domains with global list
of pending items") added a struct list_head global_list in struct
async_entry, which isn't initialised.  This means that if
!domain->registered at __async_schedule(), then list_del_init() will
be called on the list head in async_run_entry_fn with both pointers
NULL, causing a crash.  This is fixed by initialising both the
global_list and domain_list list_heads after kzalloc'ing the entry.

This was noticed due to dapm_power_widgets() which uses
ASYNC_DOMAIN_EXCLUSIVE, which initialises the domain->registered to 0.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: James Hogan <james.hogan@imgtec.com>
Reported-by: Stephen Warren <swarren@wwwdotorg.org>
kernel/async.c