netfilter: nf_nat_sip: fix incorrect handling of EBUSY for RTCP expectation
authorPablo Neira Ayuso <pablo@netfilter.org>
Wed, 29 Aug 2012 15:24:09 +0000 (15:24 +0000)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 30 Aug 2012 16:27:14 +0000 (18:27 +0200)
commit3f509c689a07a4aa989b426893d8491a7ffcc410
tree942cbba04e8ba3dbae1da488922dc4fb41b943c8
parent6fc09f10f12477bdaa54e94f9cb428bef6d81315
netfilter: nf_nat_sip: fix incorrect handling of EBUSY for RTCP expectation

We're hitting bug while trying to reinsert an already existing
expectation:

kernel BUG at kernel/timer.c:895!
invalid opcode: 0000 [#1] SMP
[...]
Call Trace:
 <IRQ>
 [<ffffffffa0069563>] nf_ct_expect_related_report+0x4a0/0x57a [nf_conntrack]
 [<ffffffff812d423a>] ? in4_pton+0x72/0x131
 [<ffffffffa00ca69e>] ip_nat_sdp_media+0xeb/0x185 [nf_nat_sip]
 [<ffffffffa00b5b9b>] set_expected_rtp_rtcp+0x32d/0x39b [nf_conntrack_sip]
 [<ffffffffa00b5f15>] process_sdp+0x30c/0x3ec [nf_conntrack_sip]
 [<ffffffff8103f1eb>] ? irq_exit+0x9a/0x9c
 [<ffffffffa00ca738>] ? ip_nat_sdp_media+0x185/0x185 [nf_nat_sip]

We have to remove the RTP expectation if the RTCP expectation hits EBUSY
since we keep trying with other ports until we succeed.

Reported-by: Rafal Fitt <rafalf@aplusc.com.pl>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/ipv4/netfilter/nf_nat_sip.c