security: Fix security_old_inode_init_security() when CONFIG_SECURITY is not set
authorJan Kara <jack@suse.cz>
Tue, 3 Jan 2012 12:14:29 +0000 (13:14 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 4 Jan 2012 00:12:19 +0000 (16:12 -0800)
commit30e053248da178cf6154bb7e950dc8713567e3fa
tree3ef4cb7f85f581fe53361ea0eb2586a8b6e696c2
parent4376eee92e5a8332b470040e672ea99cd44c826a
security: Fix security_old_inode_init_security() when CONFIG_SECURITY is not set

Commit 1e39f384bb01 ("evm: fix build problems") makes the stub version
of security_old_inode_init_security() return 0 when CONFIG_SECURITY is
not set.

But that makes callers such as reiserfs_security_init() assume that
security_old_inode_init_security() has set name, value, and len
arguments properly - but security_old_inode_init_security() left them
uninitialized which then results in interesting failures.

Revert security_old_inode_init_security() to the old behavior of
returning EOPNOTSUPP since both callers (reiserfs and ocfs2) handle this
just fine.

[ Also fixed the S_PRIVATE(inode) case of the actual non-stub
  security_old_inode_init_security() function to return EOPNOTSUPP
  for the same reason, as pointed out by Mimi Zohar.

  It got incorrectly changed to match the new function in commit
  fb88c2b6cbb1: "evm: fix security/security_old_init_security return
  code".   - Linus ]

Reported-by: Jorge Bastos <mysql.jorge@decimal.pt>
Acked-by: James Morris <jmorris@namei.org>
Acked-by: Mimi Zohar <zohar@us.ibm.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/security.h
security/security.c