dup2: Fix return value with oldfd == newfd and invalid fd
authorJeff Mahoney <jeffm@suse.com>
Mon, 11 May 2009 18:25:34 +0000 (14:25 -0400)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 11 May 2009 19:18:06 +0000 (12:18 -0700)
commit2b79bc4f7ebbd5af3c8b867968f9f15602d5f802
tree135f195357e108b1cc7b5ef0a09d1e32b79fcce0
parentfd18de50b9e7965f93d231e7390436fb8900c0e6
dup2: Fix return value with oldfd == newfd and invalid fd

The return value of dup2 when oldfd == newfd and the fd isn't valid is
not getting properly sign extended.  We end up with 4294967287 instead
of -EBADF.

I've reproduced this on SLE11 (2.6.27.21), openSUSE Factory
(2.6.29-rc5), and Ubuntu 9.04 (2.6.28).

This patch uses a signed int for the error value so it is properly
extended.

Commit 6c5d0512a091480c9f981162227fdb1c9d70e555 introduced this
regression.

Reported-by: Jiri Dluhos <jdluhos@novell.com>
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/fcntl.c