Revert "af_unix: dont send SCM_CREDENTIAL when dest socket is NULL"
authorEric W. Biederman <ebiederm@xmission.com>
Wed, 3 Apr 2013 16:13:35 +0000 (16:13 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 5 Apr 2013 04:49:03 +0000 (00:49 -0400)
commit25da0e3e9d3fb2b522bc2a598076735850310eb1
treed44a992a5e27df77cec69dd0ce19272498e402f0
parent4de79c737b200492195ebc54a887075327e1ec1d
Revert "af_unix: dont send SCM_CREDENTIAL when dest socket is NULL"

This reverts commit 14134f6584212d585b310ce95428014b653dfaf6.

The problem that the above patch was meant to address is that af_unix
messages are not being coallesced because we are sending unnecesarry
credentials.  Not sending credentials in maybe_add_creds totally
breaks unconnected unix domain sockets that wish to send credentails
to other sockets.

In practice this break some versions of udev because they receive a
message and the sending uid is bogus so they drop the message.

Reported-by: Sven Joachim <svenjoac@gmx.de>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/unix/af_unix.c