]> nv-tegra.nvidia Code Review - linux-3.10.git/commit - drivers/ieee1394
ieee1394: csr1212: proper refcounting
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Sat, 15 Sep 2007 12:50:25 +0000 (14:50 +0200)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Tue, 16 Oct 2007 21:59:59 +0000 (23:59 +0200)
commit17a19b795e9187d65b6e45cb22797725d50f7edb
tree60db3734335f3956378063c2f8126c036b83bfed
parent638d5bb8167c2c88552257d5af23f7f65ab4defd
ieee1394: csr1212: proper refcounting

At least since nodemgr got rid of coarse global locking, accesses to
struct csr1212_keyval's reference counter should be atomic and coupled
with proper barriers.  Also, calls to csr1212_keep_keyval(kv) should
occur before kv is being used.

(We probably should convert refcnt to struct kref, but how to keep
csr1212_destroy_keyval's implementation non-recursively then?)

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/ieee1394/csr1212.c
drivers/ieee1394/csr1212.h
drivers/ieee1394/nodemgr.c