7 years agomd: Add in export.h for files using EXPORT_SYMBOL
Paul Gortmaker [Fri, 27 May 2011 19:50:58 +0000]
md: Add in export.h for files using EXPORT_SYMBOL

These files were getting the defines for EXPORT_SYMBOL because
device.h was including module.h.  But we are going to put an
end to that.  So add the proper export.h include now.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agomd: Add module.h to all files using it implicitly
Paul Gortmaker [Sun, 3 Jul 2011 17:58:33 +0000]
md: Add module.h to all files using it implicitly

A pending cleanup will mean that module.h won't be implicitly
everywhere anymore.  Make sure the modular drivers in md dir
are actually calling out for <module.h> explicitly in advance.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agohid: Fix up files needing export.h for EXPORT_SYMBOL
Paul Gortmaker [Fri, 27 May 2011 14:25:27 +0000]
hid: Fix up files needing export.h for EXPORT_SYMBOL

With module.h being implicitly everywhere via device.h, the absence
of explicitly including something for EXPORT_SYMBOL went unnoticed.
Since we are heading to fix things up and clean module.h from the
device.h file, we need to explicitly include these files now.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agohid: Add module.h to fix up implicit users of it
Paul Gortmaker [Sun, 3 Jul 2011 17:39:48 +0000]
hid: Add module.h to fix up implicit users of it

A pending cleanup will mean that module.h won't be implicitly
everywhere anymore.  Make sure the modular drivers in clocksource
are actually calling out for <module.h> explicitly in advance.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agodrivers/input: add export.h to symbol exporting files.
Paul Gortmaker [Tue, 25 Oct 2011 18:51:47 +0000]
drivers/input: add export.h to symbol exporting files.

These files are not modules but are exporting symbols and/or
making use of THIS_MODULE macro.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agodrivers/input: Add module.h to modular drivers implicitly using it
Paul Gortmaker [Sun, 3 Jul 2011 17:53:48 +0000]
drivers/input: Add module.h to modular drivers implicitly using it

A pending cleanup will mean that module.h won't be implicitly
everywhere anymore.  Make sure the modular drivers in input dir
are actually calling out for <module.h> explicitly in advance.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agodrivers: power_supply_sysfs.c needs stat.h
Paul Gortmaker [Fri, 27 May 2011 14:22:46 +0000]
drivers: power_supply_sysfs.c needs stat.h

It was actually getting this before by a tangled mess of implict
includes that is going to be cleaned up.  Fix it now, so we don't
get this after the cleanup.

power_supply_sysfs.c: In function ‘power_supply_attr_is_visible’:
power_supply_sysfs.c:184: error: ‘S_IRUSR’ undeclared (first use in this function)
power_supply_sysfs.c:184: error: (Each undeclared identifier is reported only once
power_supply_sysfs.c:184: error: for each function it appears in.)
power_supply_sysfs.c:184: error: ‘S_IRGRP’ undeclared (first use in this function)
power_supply_sysfs.c:184: error: ‘S_IROTH’ undeclared (first use in this function)
power_supply_sysfs.c:196: error: ‘S_IWUSR’ undeclared (first use in this function)
make[3]: *** [drivers/power/power_supply_sysfs.o] Error 1

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agodrivers/base: transport_class explicitly requires EXPORT_SYMBOL
Paul Gortmaker [Thu, 26 May 2011 20:00:52 +0000]
drivers/base: transport_class explicitly requires EXPORT_SYMBOL

This file was getting <linux/module.h> via an implicit include
path, but we want to crush those out of existence since they cost
time during compiles of processing thousands of lines of headers
for no reason.  Give it the lightweight header that just contains
the EXPORT_SYMBOL infrastructure.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoof: of_pci.c needs export.h since it uses EXPORT_SYMBOLS
Paul Gortmaker [Fri, 27 May 2011 21:06:52 +0000]
of: of_pci.c needs export.h since it uses EXPORT_SYMBOLS

It was getting it implicitly before, since module.h was pulled
in via device.h -- but that is something we are going to make
go away soon.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoblock: Change module.h -> export.h in bsg-lib.c
Paul Gortmaker [Wed, 28 Sep 2011 22:26:05 +0000]
block: Change module.h -> export.h in bsg-lib.c

This file isn't using full modular functionality, and hence
can be "downgraded" to just using the export.h header.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoblock: Fix files that are modules and hence need module.h
Paul Gortmaker [Fri, 1 Jul 2011 19:56:05 +0000]
block: Fix files that are modules and hence need module.h

We want to remove the implicit everywhere presence of module.h
so fix up the people relying on that implicit presence in advance.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoblock: add export.h to files using EXPORT_SYMBOL/THIS_MODULE macros
Paul Gortmaker [Thu, 26 May 2011 20:00:52 +0000]
block: add export.h to files using EXPORT_SYMBOL/THIS_MODULE macros

These files were getting <linux/module.h> via an implicit include
path, but we want to crush those out of existence since they cost
time during compiles of processing thousands of lines of headers
for no reason.  Give them the lightweight header that just contains
the EXPORT_SYMBOL infrastructure.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agomtd: Add module.h to drivers users that were implicitly using it.
Paul Gortmaker [Sun, 3 Jul 2011 19:17:31 +0000]
mtd: Add module.h to drivers users that were implicitly using it.

We are cleaning up the implicit presence of module.h that these
drivers are taking advantage of.  Fix them in advance of the
cleanup operation.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agomtd: Add export.h for EXPORT_SYMBOL/THIS_MODULE where needed
Paul Gortmaker [Sun, 10 Jul 2011 16:43:28 +0000]
mtd: Add export.h for EXPORT_SYMBOL/THIS_MODULE where needed

These two common macros will be no longer present everywhere.
Call out the include needs of them explicitly where required.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agocrypto: add module.h to those files that are explicitly using it
Paul Gortmaker [Fri, 27 May 2011 18:41:48 +0000]
crypto: add module.h to those files that are explicitly using it

Part of the include cleanups means that the implicit
inclusion of module.h via device.h is going away.  So
fix things up in advance.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agodrivers/net: fix mislocated headers in cxgb4/l2t.c
Paul Gortmaker [Thu, 15 Sep 2011 23:42:40 +0000]
drivers/net: fix mislocated headers in cxgb4/l2t.c

For some reason three #include <linux/...> are buried way
down in the file.  Since the inclusion of module.h is one
of them, the inclusion comes after use of EXPORT_SYMBOL
which will cause warnings about implicit declarations.
Relocate all the headers to the top.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agodrivers/net: wireless/ath/ath5k/debug.c does not need module.h
Paul Gortmaker [Thu, 29 Sep 2011 20:37:30 +0000]
drivers/net: wireless/ath/ath5k/debug.c does not need module.h

It only has module_param and EXPORT_SYMBOL, so now that export.h
is in scope at the same time as the recent ath5k update, we can
delete this module.h include.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agodrivers/net: Add moduleparam.h to drivers as required.
Paul Gortmaker [Thu, 15 Sep 2011 23:46:05 +0000]
drivers/net: Add moduleparam.h to drivers as required.

These files were using moduleparam infrastructure, but were not
including anything for it -- which is fine when module.h is being
implicitly included in all files, but that is going away.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agodrivers/net: change moduleparam.h to module.h as required.
Paul Gortmaker [Tue, 30 Aug 2011 18:18:44 +0000]
drivers/net: change moduleparam.h to module.h as required.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agodrivers/net: Add export.h to files using EXPORT_SYMBOL/THIS_MODULE
Paul Gortmaker [Fri, 27 May 2011 20:14:23 +0000]
drivers/net: Add export.h to files using EXPORT_SYMBOL/THIS_MODULE

These were getting the macros from an implicit module.h
include via device.h, but we are planning to clean that up.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

drivers/net: Add export.h to wireless/brcm80211/brcmfmac/bcmsdh.c

This relatively recently added file uses EXPORT_SYMBOL and hence
needs export.h included so that it is compatible with the module.h
split up work.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agodrivers/net: Add module.h to drivers who were implicitly using it
Paul Gortmaker [Sun, 3 Jul 2011 19:21:01 +0000]
drivers/net: Add module.h to drivers who were implicitly using it

The device.h header was including module.h, making it present for
most of these drivers.  But we want to clean that up.  Call out the
include of module.h in the modular network drivers.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agounicore32: EXPORT_SYMBOL needs export.h
Axel Lin [Tue, 18 Oct 2011 08:51:46 +0000]
unicore32: EXPORT_SYMBOL needs export.h

Include export.h to fix below warning:

CC arch/unicore32/mm/init.o
arch/unicore32/mm/init.c:227: warning: data definition has no type or storage class
arch/unicore32/mm/init.c:227: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
arch/unicore32/mm/init.c:227: warning: parameter names (without types) in function declaration

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agomicroblaze: Add export.h to arch/microblaze files as required
Paul Gortmaker [Thu, 22 Sep 2011 15:22:55 +0000]
microblaze: Add export.h to arch/microblaze files as required

For access to the EXPORT_SYMBOL variants and THIS_MODULE macros.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agosh: Add export.h to arch/sh specific files as required.
Paul Gortmaker [Sun, 31 Jul 2011 23:20:02 +0000]
sh: Add export.h to arch/sh specific files as required.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agosh: Add module.h to arch/sh specific files as required.
Paul Gortmaker [Sun, 31 Jul 2011 23:18:02 +0000]
sh: Add module.h to arch/sh specific files as required.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agosh: fix implicit use of stat.h in arch/sh specific files
Paul Gortmaker [Sun, 31 Jul 2011 21:40:26 +0000]
sh: fix implicit use of stat.h in arch/sh specific files

To fix:

arch/sh/drivers/dma/dma-sysfs.c:45:8: error: 'S_IRUGO' undeclared here (not in a function)
arch/sh/drivers/dma/dma-sysfs.c:75:8: error: 'S_IWUSR' undeclared here (not in a function)
make[4]: *** [arch/sh/drivers/dma/dma-sysfs.o] Error 1

drivers/sh/intc/core.c:449: error: 'S_IRUGO' undeclared here (not in a function)
make[5]: *** [drivers/sh/intc/core.o] Error 1

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoalpha: Add export.h for THIS_MODULE/EXPORT_SYMBOL
Paul Gortmaker [Mon, 1 Aug 2011 17:50:15 +0000]
alpha: Add export.h for THIS_MODULE/EXPORT_SYMBOL

These files were getting it via the implicit module.h
presence that was everywhere.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoalpha: fix implicit stat.h usage in pci-sysfs.c
Paul Gortmaker [Mon, 1 Aug 2011 17:52:27 +0000]
alpha: fix implicit stat.h usage in pci-sysfs.c

To avoid this:

arch/alpha/kernel/pci-sysfs.c:164: error: 'S_IRUSR' undeclared (first use in this function)
arch/alpha/kernel/pci-sysfs.c:164: error: 'S_IWUSR' undeclared (first use in this function)
make[2]: *** [arch/alpha/kernel/pci-sysfs.o] Error 1

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoblackfin: add module.h to files implicitly expecting to use it.
Paul Gortmaker [Tue, 9 Aug 2011 20:54:30 +0000]
blackfin: add module.h to files implicitly expecting to use it.

Its presence was implicit everywhere, but we are aiming to fix that,
so call out the users explicitly.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoblackfin: Add export.h to files using EXPORT_SYMBOL/THIS_MODULE
Paul Gortmaker [Tue, 9 Aug 2011 15:05:22 +0000]
blackfin: Add export.h to files using EXPORT_SYMBOL/THIS_MODULE

These particular files were just assuming that module.h was
somehow in the include paths.  Give them the more minimalist
header file explicitly.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoparisc: add module.h to files really requiring it
Paul Gortmaker [Thu, 11 Aug 2011 17:24:07 +0000]
parisc: add module.h to files really requiring it

We want to clean up the implicit everywhere presence of module.h
which means files like this that use module infrastructure need
to explicitly call it out for inclusion.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoparisc: Add export.h to files needing EXPORT_SYMBOL/THIS_MODULE
Paul Gortmaker [Mon, 1 Aug 2011 17:12:26 +0000]
parisc: Add export.h to files needing EXPORT_SYMBOL/THIS_MODULE

These guys were getting it implicitly via module.h before,
when module.h was everywhere.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoavr32: add export.h to arch/avr32 for EXPORT_SYMBOL/THIS_MODULE
Paul Gortmaker [Mon, 1 Aug 2011 16:55:26 +0000]
avr32: add export.h to arch/avr32 for EXPORT_SYMBOL/THIS_MODULE

Add it in where the module.h implicit presence was doing
the job before.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agom68k: Add export.h to the m68k specific files as required
Paul Gortmaker [Mon, 1 Aug 2011 14:55:53 +0000]
m68k: Add export.h to the m68k specific files as required

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoia64: Add export.h to arch/ia64 specific files as required
Paul Gortmaker [Sun, 31 Jul 2011 22:33:21 +0000]
ia64: Add export.h to arch/ia64 specific files as required

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agos390: add missing module.h/export.h includes
Heiko Carstens [Sat, 30 Jul 2011 07:25:15 +0000]
s390: add missing module.h/export.h includes

Fix several compile errors on s390 caused by splitting module.h.

Some include additions [e.g. qdio_setup.c, zfcp_qdio.c] are in
anticipation of pending changes queued for s390 that increase
the modular use footprint.

[PG: added additional obvious changes since Heiko's original patch]

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agomips: add export.h to files using EXPORT_SYMBOL/THIS_MODULE
Paul Gortmaker [Thu, 28 Jul 2011 22:46:31 +0000]
mips: add export.h to files using EXPORT_SYMBOL/THIS_MODULE

Or else we get lots of variations on this:

arch/mips/pci/pci.c:330: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'

scattered throughout the build.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agomips: remove needless include of module.h from core kernel files.
Paul Gortmaker [Sat, 23 Jul 2011 20:55:17 +0000]
mips: remove needless include of module.h from core kernel files.

None of these files are using modular infrastructure, and build
tests reveal that none of these files are really relying on any
implicit inclusions via. module.h either.  So delete them.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agomips: migrate core kernel file from module.h --> export.h
Paul Gortmaker [Sat, 23 Jul 2011 20:30:40 +0000]
mips: migrate core kernel file from module.h --> export.h

These files are not modules, but were including module.h only for
EXPORT_SYMBOL and/or THIS_MODULE.  Now that we have the lightweight
export.h, use it in these kinds of cases.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agomips: fix implicit smp.h usage in various files.
Paul Gortmaker [Thu, 28 Jul 2011 23:39:02 +0000]
mips: fix implicit smp.h usage in various files.

We need to call out inclusion of smp.h, or with the module.h cleanup
we'll get things like:

arch/mips/loongson/common/platform.c:21: error: implicit declaration of function 'smp_processor_id'

arch/mips/vr41xx/common/giu.c:84: error: implicit declaration of function 'smp_processor_id'

arch/mips/vr41xx/common/rtc.c:85: error: implicit declaration of function 'smp_processor_id'

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agomips: fix implicit use of asm/elf.h in kernel/cpu-probe.c
Paul Gortmaker [Sat, 23 Jul 2011 20:26:41 +0000]
mips: fix implicit use of asm/elf.h in kernel/cpu-probe.c

We are relying on asm/elf.h being present implicitly.  Once we clean
up the root cause of that, we'll see this, so fix it in advance.

arch/mips/kernel/cpu-probe.c: In function 'set_elf_platform':
arch/mips/kernel/cpu-probe.c:298: error: '__elf_platform' undeclared (first use in this function)

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agosparc: Add module.h to files previously implicitly using it.
Paul Gortmaker [Sun, 31 Jul 2011 05:50:31 +0000]
sparc: Add module.h to files previously implicitly using it.

The file mm/extable.c needs module.h for within_module_init(), and
also for search_exception_tables [which arguably could be living somewhere
more appropriate than module.h] - eventually causing this:

arch/sparc/mm/extable.c: In function 'trim_init_extable':
arch/sparc/mm/extable.c:74: error: dereferencing pointer to incomplete type
arch/sparc/mm/extable.c:75: error: dereferencing pointer to incomplete type
arch/sparc/mm/extable.c:77: error: implicit declaration of function 'within_module_init'
arch/sparc/mm/extable.c:77: error: dereferencing pointer to incomplete type
arch/sparc/mm/extable.c:78: error: dereferencing pointer to incomplete type
arch/sparc/mm/extable.c:80: error: dereferencing pointer to incomplete type
arch/sparc/mm/extable.c: In function 'search_extables_range':
arch/sparc/mm/extable.c:93: error: implicit declaration of function 'search_exception_tables'

The other instances are more straight forward uses of things
like MODULE_* and module_*

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agosparc: remove several unnecessary module.h include instances
Paul Gortmaker [Fri, 22 Jul 2011 12:02:24 +0000]
sparc: remove several unnecessary module.h include instances

Building an allyesconfig doesn't reveal a hidden need
for any of these.  Since module.h brings in the whole kitchen
sink, it just needlessly adds 30k+ lines to the cpp burden.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agosparc: move symbol exporters to use export.h not module.h
Paul Gortmaker [Fri, 22 Jul 2011 17:18:16 +0000]
sparc: move symbol exporters to use export.h not module.h

Many of the core sparc kernel files are not modules, but just
including module.h for exporting symbols.  Now these files can
use the lighter footprint export.h for this role.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agosparc: add export.h to arch/sparc files as required
Paul Gortmaker [Mon, 18 Jul 2011 19:57:46 +0000]
sparc: add export.h to arch/sparc files as required

These files are only exporting symbols, so they don't need
the full module.h header file.  Previously they were getting
access to EXPORT_SYMBOL implicitly via overuse of module.h
from within other .h files, but that is being cleaned up.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agosparc: fix implicit use of uaccess.h header in mdesc.c
Paul Gortmaker [Tue, 20 Sep 2011 01:15:28 +0000]
sparc: fix implicit use of uaccess.h header in mdesc.c

Building sparc64 with the module.h cleanup reveals this implicit
include being taken advantage of:

arch/sparc/kernel/mdesc.c: In function 'mdesc_read':
arch/sparc/kernel/mdesc.c:900: error: implicit declaration of function 'copy_to_user'

Fix it up before the implicit module.h presence is removed.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agosparc: fix implicit use of spitfire.h in pcr.c and of_device_64.c
Paul Gortmaker [Mon, 1 Aug 2011 17:42:48 +0000]
sparc: fix implicit use of spitfire.h in pcr.c and of_device_64.c

To resolve these on 64bit allnoconfig builds:

CC arch/sparc/kernel/pcr.o
arch/sparc/kernel/pcr.c: In function 'register_perf_hsvc':
arch/sparc/kernel/pcr.c:102: error: 'tlb_type' undeclared (first use in this function)

CC arch/sparc/kernel/of_device_64.o
arch/sparc/kernel/of_device_64.c: In function 'build_device_resources':
arch/sparc/kernel/of_device_64.c:406: error: 'tlb_type' undeclared (first use in this function)

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoarm: Add moduleparam.h to arch/arm files as required
Paul Gortmaker [Sun, 18 Sep 2011 18:50:33 +0000]
arm: Add moduleparam.h to arch/arm files as required

Things like module_param and core_param come from the header
moduleparam.h -- these files were relying on the fact that
module.h is implicitly present everywhere and it in turn
includes the moduleparam header.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoarm: fix implicit module.h users by adding it to arch/arm as required.
Paul Gortmaker [Sun, 31 Jul 2011 20:14:14 +0000]
arm: fix implicit module.h users by adding it to arch/arm as required.

These files will fail to compile if we dont clean them up in advance
and have them include the appropriate headers they need.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoarm: Add export.h to ARM specific files as required.
Paul Gortmaker [Sun, 31 Jul 2011 20:17:29 +0000]
arm: Add export.h to ARM specific files as required.

These files all make use of one of the EXPORT_SYMBOL variants
or the THIS_MODULE macro.  So they will need <linux/export.h>

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoarm: convert core files from module.h to export.h
Paul Gortmaker [Fri, 22 Jul 2011 14:58:34 +0000]
arm: convert core files from module.h to export.h

Many of the core ARM kernel files are not modules, but just
including module.h for exporting symbols.  Now these files can
use the lighter footprint export.h for this role.

There are probably lots more, but ARM files of mach-* and plat-*
don't get coverage via a simple yesconfig build.  They will have
to be cleaned up and tested via using their respective configs.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoarm: remove several unnecessary module.h include instances
Paul Gortmaker [Fri, 22 Jul 2011 14:29:08 +0000]
arm: remove several unnecessary module.h include instances

Building these files does not reveal a hidden need for
any of these.  Since module.h brings in the whole kitchen
sink, it just needlessly adds 30k+ lines to the cpp burden.

There are probably lots more, but ARM files of mach-* and plat-*
don't get coverage via a simple yesconfig build.  They will have
to be cleaned up and tested via using their respective configs.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoarm: add slab.h to plat-samsung files for GFP_KERNEL
Paul Gortmaker [Sun, 31 Jul 2011 22:16:56 +0000]
arm: add slab.h to plat-samsung files for GFP_KERNEL

To fix messages like this:

CC arch/arm/plat-samsung/platformdata.o
arch/arm/plat-samsung/platformdata.c: In function 's3c_set_platdata':
arch/arm/plat-samsung/platformdata.c:29: error: 'GFP_KERNEL' undeclared (first use in this function)
arch/arm/plat-samsung/platformdata.c:29: error: (Each undeclared identifier is reported only once
arch/arm/plat-samsung/platformdata.c:29: error: for each function it appears in.)
make[3]: *** [arch/arm/plat-samsung/platformdata.o] Error 1

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoarm: fix implicit use of sched.h in bcmring/dma.c
Paul Gortmaker [Sun, 31 Jul 2011 21:04:15 +0000]
arm: fix implicit use of sched.h in bcmring/dma.c

To fix this:

arch/arm/mach-bcmring/dma.c: In function 'dma_request_channel_dbg':
arch/arm/mach-bcmring/dma.c:1022: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
arch/arm/mach-bcmring/dma.c:1022: error: (Each undeclared identifier is reported only once

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoarm: fix implicit use of moduleparam in mach-mx31*.c
Paul Gortmaker [Sun, 31 Jul 2011 23:01:27 +0000]
arm: fix implicit use of moduleparam in mach-mx31*.c

To get the definition of core_param() they need this header.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoarm: fix implicit use of page.h in several arch/arm files
Paul Gortmaker [Sun, 31 Jul 2011 22:38:45 +0000]
arm: fix implicit use of page.h in several arch/arm files

Add the include to fix things like this:

arch/arm/mach-sa1100/jornada720.c:278: error: 'PAGE_SHIFT' undeclared here (not in a function)
arch/arm/mach-bcmring/mm.c:32: error: 'PAGE_SHIFT' undeclared here (not in a function)
arch/arm/mach-sa1100/collie.c:361: error: 'PAGE_SHIFT' undeclared here (not in a function)

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoarm: fix implicit memset/string.h usage in various arch/arm files
Paul Gortmaker [Sun, 31 Jul 2011 14:52:44 +0000]
arm: fix implicit memset/string.h usage in various arch/arm files

To fix things like this:

arch/arm/mach-omap2/usb-tusb6010.c:58: error: implicit declaration of function 'memset'
arch/arm/kernel/leds.c:40: error: implicit declaration of function 'strcspn'
arch/arm/kernel/leds.c:40: warning: incompatible implicit declaration of built-in function 'strcspn'
arch/arm/kernel/leds.c:45: error: implicit declaration of function 'strncmp'
arch/arm/kernel/leds.c:55: error: implicit declaration of function 'strlen'
arch/arm/kernel/leds.c:55: warning: incompatible implicit declaration of built-in function 'strlen'
arch/arm/mach-omap2/clockdomain.c:52: error: implicit declaration of function 'strcmp'

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoarm: add elf.h to arch/arm/kernel/ptrace.c
Paul Gortmaker [Mon, 18 Jul 2011 16:03:53 +0000]
arm: add elf.h to arch/arm/kernel/ptrace.c

It was implicitly getting it via an implicit presence of module.h
but when we clean that up, we'll get a bunch of lines like this:

arch/arm/kernel/ptrace.c:764: error: 'NT_PRSTATUS' undeclared here (not in a function)
arch/arm/kernel/ptrace.c:765: error: 'ELF_NGREG' undeclared here (not in a function)
arch/arm/kernel/ptrace.c:776: error: 'NT_PRFPREG' undeclared here (not in a function)

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agopowerpc: remove non-required uses of include <linux/module.h>
Paul Gortmaker [Fri, 22 Jul 2011 18:24:04 +0000]
powerpc: remove non-required uses of include <linux/module.h>

None of the files touched here are modules, and they are not
exporting any symbols either -- so there is no need to be including
the module.h.  Builds of all the files remains successful.

Even kernel/module.c does not need to include it, since it includes
linux/moduleloader.h instead.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agopowerpc: various straight conversions from module.h --> export.h
Paul Gortmaker [Fri, 22 Jul 2011 22:24:23 +0000]
powerpc: various straight conversions from module.h --> export.h

All these files were including module.h just for the basic
EXPORT_SYMBOL infrastructure.  We can shift them off to the
export.h header which is a way smaller footprint and thus
realize some compile time gains.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agopowerpc: convert hvconsole.c to export.h ; fix implicit use of errno.h
Paul Gortmaker [Fri, 22 Jul 2011 22:15:07 +0000]
powerpc: convert hvconsole.c to export.h ; fix implicit use of errno.h

This file is only exporting symbols and so should use export.h
and not module.h header.  But in doing the conversion, we will
uncover that it was implicitly using errno.h via module.h:

CC arch/powerpc/platforms/pseries/hvconsole.o
arch/powerpc/platforms/pseries/hvconsole.c: In function 'hvc_put_chars':
arch/powerpc/platforms/pseries/hvconsole.c:77: error: 'EIO' undeclared (first use in this function)

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agopowerpc: fix two implicit header uses in pseries/plpar_wrappers.h
Paul Gortmaker [Fri, 22 Jul 2011 22:04:33 +0000]
powerpc: fix two implicit header uses in pseries/plpar_wrappers.h

Removing the implicit presence of module.h from almost everywhere
will reveal this implicit usage of paca.h and string.h headers as
follows:

arch/powerpc/platforms/pseries/plpar_wrappers.h:22: error: implicit declaration of function 'get_lppaca'
arch/powerpc/platforms/pseries/plpar_wrappers.h:208: error: implicit declaration of function 'memcpy'

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agopowerpc: fix implicit use of mutex.h by include/asm/spu.h
Paul Gortmaker [Fri, 22 Jul 2011 18:00:05 +0000]
powerpc: fix implicit use of mutex.h by include/asm/spu.h

We've been getting the header implicitly via module.h in the past
but when we clean that up, we'll get this failure:

CC arch/powerpc/platforms/cell/beat_spu_priv1.o
In file included from arch/powerpc/platforms/cell/beat_spu_priv1.c:22:
arch/powerpc/include/asm/spu.h:190: error: field 'list_mutex' has incomplete type
make[2]: *** [arch/powerpc/platforms/cell/beat_spu_priv1.o] Error 1

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agopowerpc: fix implicit use of cache.h in kernel/firmware.c
Paul Gortmaker [Fri, 22 Jul 2011 19:07:20 +0000]
powerpc: fix implicit use of cache.h in kernel/firmware.c

This file only needs export.h to get EXPORT_SYMBOL, but in doing
so, it uncovers an implicit use of linux/cache.h as follows:

CC arch/powerpc/kernel/firmware.o
arch/powerpc/kernel/firmware.c:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__read_mostly'
arch/powerpc/kernel/firmware.c:21: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__used'
make[2]: *** [arch/powerpc/kernel/firmware.o] Error 1

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agopowerpc: fix implicit notifier use in converting to export.h
Paul Gortmaker [Fri, 22 Jul 2011 19:15:09 +0000]
powerpc: fix implicit notifier use in converting to export.h

We can convert this file to using export.h since it only wants
to export symbols, but when we do we'll see also that it was
implicitly getting notifier.h from module.h via this failure:

CC arch/powerpc/platforms/cell/spu_notify.o
arch/powerpc/platforms/cell/spu_notify.c:28: warning: type defaults to 'int' in declaration of 'BLOCKING_NOTIFIER_HEAD'
arch/powerpc/platforms/cell/spu_notify.c:28: warning: parameter names (without types) in function declaration
arch/powerpc/platforms/cell/spu_notify.c: In function 'spu_switch_notify':
arch/powerpc/platforms/cell/spu_notify.c:32: error: implicit declaration of function 'blocking_notifier_call_chain'
arch/powerpc/platforms/cell/spu_notify.c:32: error: 'spu_switch_notifier' undeclared (first use in this function)

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agopowerpc: cell/beat_wrapper.h is implicitly using memcpy functions
Paul Gortmaker [Fri, 22 Jul 2011 17:52:47 +0000]
powerpc: cell/beat_wrapper.h is implicitly using memcpy functions

This has been relying on the fact that the parent file would have
module.h (and thus nearly everything) present.  But once we fix that,
we'll get stuck with this failure:

In file included from arch/powerpc/platforms/cell/beat_spu_priv1.c:26:
arch/powerpc/platforms/cell/beat_wrapper.h: In function 'beat_eeprom_write':
arch/powerpc/platforms/cell/beat_wrapper.h:160: error: implicit declaration of function 'memcpy'

and many more instances of the same.  Fix it in advance.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agopowerpc: Fix up implicit sched.h users
Paul Gortmaker [Fri, 27 May 2011 18:25:11 +0000]
powerpc: Fix up implicit sched.h users

They are getting it through device.h --> module.h path, but we want
to clean that up.  This is a sample of what will happen if we don't:

  pseries/iommu.c: In function 'tce_build_pSeriesLP':
  pseries/iommu.c:136: error: implicit declaration of function 'show_stack'

  pseries/eeh.c: In function 'eeh_token_to_phys':
  pseries/eeh.c:359: error: 'init_mm' undeclared (first use in this function)

  pseries/eeh_event.c: In function 'eeh_event_handler':
  pseries/eeh_event.c:63: error: implicit declaration of function 'daemonize'
  pseries/eeh_event.c:64: error: implicit declaration of function 'set_current_state'
  pseries/eeh_event.c:64: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
  pseries/eeh_event.c:64: error: (Each undeclared identifier is reported only once
  pseries/eeh_event.c:64: error: for each function it appears in.)
  pseries/eeh_event.c: In function 'eeh_thread_launcher':
  pseries/eeh_event.c:109: error: 'CLONE_KERNEL' undeclared (first use in this function)

  hotplug-cpu.c: In function 'pseries_mach_cpu_die':
  hotplug-cpu.c:115: error: implicit declaration of function 'idle_task_exit'

  kernel/swsusp_64.c: In function 'do_after_copyback':
  kernel/swsusp_64.c:17: error: implicit declaration of function 'touch_softlockup_watchdog'

  cell/spufs/context.c: In function 'alloc_spu_context':
  cell/spufs/context.c:60: error: implicit declaration of function 'get_task_mm'
  cell/spufs/context.c:60: warning: assignment makes pointer from integer without a cast
  cell/spufs/context.c: In function 'spu_forget':
  cell/spufs/context.c:127: error: implicit declaration of function 'mmput'

  pasemi/dma_lib.c: In function 'pasemi_dma_stop_chan':
  pasemi/dma_lib.c:332: error: implicit declaration of function 'cond_resched'

  sysdev/fsl_lbc.c: In function 'fsl_lbc_ctrl_irq':
  sysdev/fsl_lbc.c:247: error: 'TASK_NORMAL' undeclared (first use in this function)

Add in sched.h so these get the definitions they are looking for.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agopowerpc: Fix up implicit stat.h users
Paul Gortmaker [Fri, 27 May 2011 17:27:45 +0000]
powerpc: Fix up implicit stat.h users

They get it via module.h (via device.h) but we want to clean that up.
When we do, we'll get things like:

ibmebus.c:314: error: 'S_IWUSR' undeclared here (not in a function)
vio.c:972: error: 'S_IWUSR' undeclared here (not in a function)

so add in the stat header it is using explicitly in advance.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agopowerpc: Fix up modules that should be including module.h
Paul Gortmaker [Fri, 27 May 2011 17:23:32 +0000]
powerpc: Fix up modules that should be including module.h

So that we can clean up the header files and not be relying
on implicit includes from device.h ---> module.h

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agopowerpc: include export.h for files using EXPORT_SYMBOL/THIS_MODULE
Paul Gortmaker [Fri, 29 Jul 2011 06:19:31 +0000]
powerpc: include export.h for files using EXPORT_SYMBOL/THIS_MODULE

Fix failures in powerpc associated with the previously allowed
implicit module.h presence that now lead to things like this:

arch/powerpc/mm/mmu_context_hash32.c:76:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/powerpc/mm/tlb_hash32.c:48:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
arch/powerpc/kernel/pci_32.c:51:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/powerpc/kernel/iomap.c:36:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
arch/powerpc/platforms/44x/canyonlands.c:126:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
arch/powerpc/kvm/44x.c:168:59: error: 'THIS_MODULE' undeclared (first use in this function)

[with several contibutions from Stephen Rothwell <sfr@canb.auug.org.au>]

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agopowerpc: add export.h to files making use of EXPORT_SYMBOL
Paul Gortmaker [Fri, 27 May 2011 14:46:24 +0000]
powerpc: add export.h to files making use of EXPORT_SYMBOL

With module.h being implicitly everywhere via device.h, the absence
of explicitly including something for EXPORT_SYMBOL went unnoticed.
Since we are heading to fix things up and clean module.h from the
device.h file, we need to explicitly include these files now.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agopowerpc: io-workarounds.c was implicitly getting init_mm
Paul Gortmaker [Fri, 27 May 2011 17:39:01 +0000]
powerpc: io-workarounds.c was implicitly getting init_mm

It was coming in via device.h --> module.h etc. but we want to
clean that up.  So explicitly include the header where init_mm
is being declared.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agox86: efi_32.c is implicitly getting asm/desc.h via module.h
Paul Gortmaker [Fri, 27 May 2011 18:46:07 +0000]
x86: efi_32.c is implicitly getting asm/desc.h via module.h

We want to clean up the chain of includes stumbling through
module.h, and when we do that, we'll see:

CC arch/x86/platform/efi/efi_32.o
  efi/efi_32.c: In function ‘efi_call_phys_prelog’:
  efi/efi_32.c:80: error: implicit declaration of function ‘get_cpu_gdt_table’
  efi/efi_32.c:82: error: implicit declaration of function ‘load_gdt’
  make[4]: *** [arch/x86/platform/efi/efi_32.o] Error 1

Include asm/desc.h so that there are no implicit include assumptions.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agox86: fix up files really needing to include module.h
Paul Gortmaker [Fri, 27 May 2011 16:33:10 +0000]
x86: fix up files really needing to include module.h

These files aren't just exporting symbols -- they are also defining
a MODULE_LICENSE etc. so give them the full module.h file.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agox86: Fix files explicitly requiring export.h for EXPORT_SYMBOL/THIS_MODULE
Paul Gortmaker [Thu, 26 May 2011 16:22:53 +0000]
x86: Fix files explicitly requiring export.h for EXPORT_SYMBOL/THIS_MODULE

These files were implicitly getting EXPORT_SYMBOL via device.h
which was including module.h, but that will be fixed up shortly.

By fixing these now, we can avoid seeing things like:

arch/x86/kernel/rtc.c:29: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL’
arch/x86/kernel/pci-dma.c:20: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL’
arch/x86/kernel/e820.c:69: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’

[ with input from Randy Dunlap <rdunlap@xenotime.net> and also
  from Stephen Rothwell <sfr@canb.auug.org.au> ]

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agox86: fix implicit include of <linux/topology.h> in vsyscall_64
Paul Gortmaker [Thu, 26 May 2011 16:33:18 +0000]
x86: fix implicit include of <linux/topology.h> in vsyscall_64

In removing the presence of <linux/module.h> from some of the
more common <linux/something.h> files, this implict include
of <linux/topology.h> was uncovered.

CC arch/x86/kernel/vsyscall_64.o
  arch/x86/kernel/vsyscall_64.c: In function ‘vsyscall_set_cpu’:
  arch/x86/kernel/vsyscall_64.c:259: error: implicit declaration of function ‘cpu_to_node’

Explicitly call it out so the cleanup can take place.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoacpi: add export.h to files using THIS_MODULE/EXPORT_SYMBOL
Paul Gortmaker [Wed, 26 Oct 2011 20:22:14 +0000]
acpi: add export.h to files using THIS_MODULE/EXPORT_SYMBOL

These files were relying on module.h to come in via the path
in an include/acpi header file, but we don't want to have
instances of module.h being included from include/* files
if it can be avoided.  Have the files include export.h instead.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoacpi: downgrade files from module.h to export.h where possible.
Paul Gortmaker [Wed, 26 Oct 2011 21:58:35 +0000]
acpi: downgrade files from module.h to export.h where possible.

If a file is only exporting symbols and not using the core
modular infrastructure, it can get by with just including
the smaller export.h header, which is a lot smaller than the
module.h header.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoacpi: delete module.h include from files explicitly not needing it
Paul Gortmaker [Wed, 26 Oct 2011 21:56:09 +0000]
acpi: delete module.h include from files explicitly not needing it

Files which aren't actually using infrastructure from module.h
shouldn't include it, as it is a big header with lots of child
includes spawned off.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agoacpi: add module.h to files implicitly using/relying on it.
Paul Gortmaker [Fri, 1 Jul 2011 18:30:49 +0000]
acpi: add module.h to files implicitly using/relying on it.

These files are using standard module API things like MODULE_AUTHOR
etc. and so should not be relying on an implicit presence of the
module.h header.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agofs: add module.h to files that were implicitly using it
Paul Gortmaker [Fri, 1 Jul 2011 18:23:34 +0000]
fs: add module.h to files that were implicitly using it

Some files were using the complete module.h infrastructure without
actually including the header at all.  Fix them up in advance so
once the implicit presence is removed, we won't get failures like this:

CC [M] fs/nfsd/nfssvc.o
fs/nfsd/nfssvc.c: In function 'nfsd_create_serv':
fs/nfsd/nfssvc.c:335: error: 'THIS_MODULE' undeclared (first use in this function)
fs/nfsd/nfssvc.c:335: error: (Each undeclared identifier is reported only once
fs/nfsd/nfssvc.c:335: error: for each function it appears in.)
fs/nfsd/nfssvc.c: In function 'nfsd':
fs/nfsd/nfssvc.c:555: error: implicit declaration of function 'module_put_and_exit'
make[3]: *** [fs/nfsd/nfssvc.o] Error 1

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agofs: add export.h to files using EXPORT_SYMBOL/THIS_MODULE macros
Paul Gortmaker [Thu, 26 May 2011 20:00:52 +0000]
fs: add export.h to files using EXPORT_SYMBOL/THIS_MODULE macros

These files were getting <linux/module.h> via an implicit include
path, but we want to crush those out of existence since they cost
time during compiles of processing thousands of lines of headers
for no reason.  Give them the lightweight header that just contains
the EXPORT_SYMBOL infrastructure.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agonet: fix implicit kmod.h usage in bridge/br_stp_if.c
Paul Gortmaker [Mon, 29 Aug 2011 21:55:05 +0000]
net: fix implicit kmod.h usage in bridge/br_stp_if.c

To fix this, once the implicit presence of module.h is removed:

net/bridge/br_stp_if.c: In function ‘br_stp_start’:
net/bridge/br_stp_if.c:131: error: implicit declaration of function ‘call_usermodehelper’
net/bridge/br_stp_if.c:131: error: ‘UMH_WAIT_PROC’ undeclared (first use in this function)

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agonet: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules
Paul Gortmaker [Fri, 15 Jul 2011 15:47:34 +0000]
net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules

These files are non modular, but need to export symbols using
the macros now living in export.h -- call out the include so
that things won't break when we remove the implicit presence
of module.h from everywhere.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agonet: add moduleparam.h for users of module_param/MODULE_PARM_DESC
Paul Gortmaker [Sun, 18 Sep 2011 17:21:27 +0000]
net: add moduleparam.h for users of module_param/MODULE_PARM_DESC

These files were getting access to these two via the implicit
presence of module.h everywhere.  They aren't modules, so they
don't need the full module.h inclusion though.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agonet: Fix files explicitly needing to include module.h
Paul Gortmaker [Fri, 27 May 2011 13:12:25 +0000]
net: Fix files explicitly needing to include module.h

With calls to modular infrastructure, these files really
needs the full module.h header.  Call it out so some of the
cleanups of implicit and unrequired includes elsewhere can be
cleaned up.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agokernel: Fix files explicitly needing EXPORT_SYMBOL infrastructure
Paul Gortmaker [Thu, 26 May 2011 20:00:52 +0000]
kernel: Fix files explicitly needing EXPORT_SYMBOL infrastructure

These files were getting <linux/module.h> via an implicit non-obvious
path, but we want to crush those out of existence since they cost
time during compiles of processing thousands of lines of headers
for no reason.  Give them the lightweight header that just contains
the EXPORT_SYMBOL infrastructure.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agokernel: fix up module header handling in rcutiny files
Paul Gortmaker [Tue, 25 Oct 2011 17:13:57 +0000]
kernel: fix up module header handling in rcutiny files

The file rcutiny.c does not need moduleparam.h header, as
there are no modparams in this file.

However rcutiny_plugin.h does define a module_init() and
a module_exit() and it uses the various MODULE_ macros, so
it really does need module.h included.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agokernel: params.c needs module.h not moduleparam.h
Paul Gortmaker [Fri, 27 May 2011 01:07:10 +0000]
kernel: params.c needs module.h not moduleparam.h

Through various other implicit include paths, some files were
getting the full module.h file, and hence living the illusion
that they really only needed moduleparam.h -- but the reality
is that once you remove the module.h presence, these show up:

kernel/params.c:583: warning: ‘struct module_kobject’ declared inside parameter list

Such files really require module.h so simply make it so.  As the
file module.h grabs moduleparam.h on the fly, all will be well.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agokernel: ksysfs.c is implicitly using stat.h
Paul Gortmaker [Thu, 28 Jul 2011 18:22:29 +0000]
kernel: ksysfs.c is implicitly using stat.h

With the module.h usage cleanup, we'll get this:

kernel/ksysfs.c:161: error: ‘S_IRUGO’ undeclared here (not in a function)
make[2]: *** [kernel/ksysfs.o] Error 1

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agokernel: fix two implicit header assumptions in irq_work.c
Paul Gortmaker [Mon, 18 Jul 2011 17:03:04 +0000]
kernel: fix two implicit header assumptions in irq_work.c

Up until now, this file was getting percpu.h because nearly every
file was implicitly getting module.h (and all its sub-includes).
But we want to clean that up, so call out percpu.h explicitly.
Otherwise we'll get things like this on an ARM build:

kernel/irq_work.c:48: error: expected declaration specifiers or '...' before 'irq_work_list'
kernel/irq_work.c:48: warning: type defaults to 'int' in declaration of 'DEFINE_PER_CPU'

The same thing was happening for builds on ARM for asm/processor.h

kernel/irq_work.c: In function 'irq_work_sync':
kernel/irq_work.c:166: error: implicit declaration of function 'cpu_relax'

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agokernel: fix several implicit usasges of kmod.h
Paul Gortmaker [Thu, 26 May 2011 16:48:41 +0000]
kernel: fix several implicit usasges of kmod.h

These files were implicitly relying on <linux/kmod.h> coming in via
module.h, as without it we get things like:

kernel/power/suspend.c:100: error: implicit declaration of function ‘usermodehelper_disable’
kernel/power/suspend.c:109: error: implicit declaration of function ‘usermodehelper_enable’
kernel/power/user.c:254: error: implicit declaration of function ‘usermodehelper_disable’
kernel/power/user.c:261: error: implicit declaration of function ‘usermodehelper_enable’

kernel/sys.c:317: error: implicit declaration of function ‘usermodehelper_disable’
kernel/sys.c:1816: error: implicit declaration of function ‘call_usermodehelper_setup’
kernel/sys.c:1822: error: implicit declaration of function ‘call_usermodehelper_setfns’
kernel/sys.c:1824: error: implicit declaration of function ‘call_usermodehelper_exec’

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agokernel: Add <linux/module.h> to files using it implicitly
Paul Gortmaker [Thu, 26 May 2011 21:53:52 +0000]
kernel: Add <linux/module.h> to files using it implicitly

These files are doing things like module_put and try_module_get
so they need to call out the module.h for explicit inclusion,
rather than getting it via <linux/device.h> which we ideally want
to remove the module.h inclusion from.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agokernel: Map most files to use export.h instead of module.h
Paul Gortmaker [Mon, 23 May 2011 18:51:41 +0000]
kernel: Map most files to use export.h instead of module.h

The changed files were only including linux/module.h for the
EXPORT_SYMBOL infrastructure, and nothing else.  Revector them
onto the isolated export header for faster compile times.

Nothing to see here but a whole lot of instances of:

  -#include <linux/module.h>
  +#include <linux/export.h>

This commit is only changing the kernel dir; next targets
will probably be mm, fs, the arch dirs, etc.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agomm: fix implicit stat.h usage in dmapool.c
Paul Gortmaker [Sun, 16 Oct 2011 06:03:46 +0000]
mm: fix implicit stat.h usage in dmapool.c

The removal of the implicitly everywhere module.h and its child includes
will reveal this implicit stat.h usage:

mm/dmapool.c:108: error: ‘S_IRUGO’ undeclared here (not in a function)

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agomm: Map most files to use export.h instead of module.h
Paul Gortmaker [Sun, 16 Oct 2011 06:01:52 +0000]
mm: Map most files to use export.h instead of module.h

The files changed within are only using the EXPORT_SYMBOL
macro variants.  They are not using core modular infrastructure
and hence don't need module.h but only the export.h header.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agomm: Add export.h for EXPORT_SYMBOL to active symbol exporters
Paul Gortmaker [Thu, 26 May 2011 20:00:52 +0000]
mm: Add export.h for EXPORT_SYMBOL to active symbol exporters

These files were getting <linux/module.h> via an implicit include
path, but we want to crush those out of existence since they cost
time during compiles of processing thousands of lines of headers
for no reason.  Give them the lightweight header that just contains
the EXPORT_SYMBOL infrastructure.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agomm: delete various needless include <linux/module.h>
Paul Gortmaker [Thu, 26 May 2011 19:58:15 +0000]
mm: delete various needless include <linux/module.h>

There is nothing modular in these files, and no reason to drag
in all the 357 headers that module.h brings with it, since
it just slows down compiles.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agorange: fix bogus misuse of module.h to get printk()
Paul Gortmaker [Wed, 25 May 2011 13:52:21 +0000]
range: fix bogus misuse of module.h to get printk()

This file isn't doing anything with modules and so it should
not be including <linux/module.h> just to get basic stuff
like printk() and min/max.  Revector it to <linux/kernel.h>.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

7 years agomodule.h: relocate MODULE_PARM_DESC into moduleparam.h
Paul Gortmaker [Tue, 30 Aug 2011 15:24:44 +0000]
module.h: relocate MODULE_PARM_DESC into moduleparam.h

There are files which use module_param and MODULE_PARM_DESC
back to back.  They only include moduleparam.h which makes sense,
but the implicit presence of module.h everywhere hid the fact
that MODULE_PARM_DESC wasn't in moduleparam.h at all.  Relocate
the macro to moduleparam.h so that the moduleparam infrastructure
can be used independently of module.h

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>