8 years agohv: rename prep_negotiate_resp() to vmbus_prep_negotiate_resp()
Greg Kroah-Hartman [Tue, 11 Oct 2011 14:42:28 +0000]
hv: rename prep_negotiate_resp() to vmbus_prep_negotiate_resp()

It's a global symbol, so properly prefix it and use the proper EXPORT
value as well.

Cc: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: remove unneeded asm include file in hyperv.h
Greg Kroah-Hartman [Tue, 11 Oct 2011 14:36:44 +0000]
Staging: hv: remove unneeded asm include file in hyperv.h

No one outside of the hyperv core needs to include the asm/hyperv.h
file, so don't put it in the "global" include/linux/hyperv.h file.

Cc: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: move hyperv code out of staging directory
Greg Kroah-Hartman [Tue, 4 Oct 2011 19:29:52 +0000]
Staging: hv: move hyperv code out of staging directory

After many years wandering the desert, it is finally time for the
Microsoft HyperV code to move out of the staging directory.  Or at least
the core hyperv bus code, and the utility driver, the rest still have
some review to get through by the various subsystem maintainers.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>

8 years agoStaging: hv: netvsc: Fix a dereferencing issue
K. Y. Srinivasan [Thu, 6 Oct 2011 17:10:56 +0000]
Staging: hv: netvsc: Fix a dereferencing issue

net_dev is being de-referenced without proper checking; fix it.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: hv: storvsc: ignore SET_WINDOW scsi command
Olaf Hering [Mon, 10 Oct 2011 07:37:39 +0000]
staging: hv: storvsc: ignore SET_WINDOW scsi command

Some commands sent by smartd will offline the device.
With this change applied, smartd sill not monitor the device anymore.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: util: Invoke cn_netlink_send() in a work context
K. Y. Srinivasan [Mon, 10 Oct 2011 02:42:28 +0000]
Staging: hv: util: Invoke cn_netlink_send() in a work context

Invoke cn_netlink_send() in a work context as opposed being called
in the context of  channel callback. On entry into the channel callback
code the channel inbound spin lock is held and deferring to a work
context avoids having to invoke cn_netlink_send() while holding
the inbound lock. As part of this adjustment, also increase the
timeout value for waiting for the user level component of KVP.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: util: Fix a bug in kvp implementation
K. Y. Srinivasan [Tue, 4 Oct 2011 21:00:02 +0000]
Staging: hv: util: Fix a bug in kvp implementation

The host gurantees that there can be only one kvp transaction active
against the guest. So, the transaction active state is needed only to
protect against spurious user level calls. The current code had a race
condition where the guest could prematurely return because the previous
transaction state was not cleared - this state was being cleared after
sending the response to the host and there was a window where the host
could notify the guest of a new transaction before the transaction active
state was properly set.
Also deal with the case when the user mode component
does not respond in a timely fashion correctly.
I would like to thank Long Li <longli@microsoft.com>
for identifying the problem.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Diagnosed-by: Long Li <longli@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging:iio:resolver:ad2s1210 cleanup gpio handling.
Jonathan Cameron [Wed, 5 Oct 2011 14:28:06 +0000]
staging:iio:resolver:ad2s1210 cleanup gpio handling.

Basically make use of the gpio array functions.
Technically the free doesn't need as much info
as given here, but this keeps it clean and easy
to follow.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging:iio:resolver:ad2s1210 drop raw config register access
Jonathan Cameron [Wed, 5 Oct 2011 14:28:05 +0000]
staging:iio:resolver:ad2s1210 drop raw config register access

This should never have been exposed to userspace

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging:iio:resolver:ad2s1210 minimal chan spec conversion.
Jonathan Cameron [Wed, 5 Oct 2011 14:28:04 +0000]
staging:iio:resolver:ad2s1210 minimal chan spec conversion.

Just convert the raw reads in this patch.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging:iio:resolver:ad2s1210 ensure iio_dev->name is set
Jonathan Cameron [Wed, 5 Oct 2011 14:28:03 +0000]
staging:iio:resolver:ad2s1210 ensure iio_dev->name is set

This is needed to ensure the required name attribute is
created. Using an id table is the route most consistent
with other drivers.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging:iio:resolver rename ad2s120x ->ad2s1200
Jonathan Cameron [Wed, 5 Oct 2011 14:28:02 +0000]
staging:iio:resolver rename ad2s120x ->ad2s1200

There are far too many possible part numbers that are
not covered in here to have such a generic name.
So move to naming after one of the supported parts.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging:iio:resolver:ad2s120x chan spec conversion
Jonathan Cameron [Wed, 5 Oct 2011 14:28:01 +0000]
staging:iio:resolver:ad2s120x chan spec conversion

Straight forward conversion.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging:iio:Documentation gyro -> anglvel updates in attribute names
Jonathan Cameron [Wed, 5 Oct 2011 14:28:00 +0000]
staging:iio:Documentation gyro -> anglvel updates in attribute names

Follows directly from change made in previous patch.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging:iio: rename gyro channels to anglvel
Jonathan Cameron [Wed, 5 Oct 2011 14:27:59 +0000]
staging:iio: rename gyro channels to anglvel

Ensure naming reflects what is measured, not how it is done.
Resolvers can measure the same thing for starters.
IIO_GYRO->IIO_ANGL_VEL to ensure consistent naming.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging:iio:resolver:ad2s90 chan spec conversion
Jonathan Cameron [Wed, 5 Oct 2011 14:27:58 +0000]
staging:iio:resolver:ad2s90 chan spec conversion

Trivial conversion.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging:iio:resolver:ad2s90 ensure name is passed to iio_core.
Jonathan Cameron [Wed, 5 Oct 2011 14:27:57 +0000]
staging:iio:resolver:ad2s90 ensure name is passed to iio_core.

Scraps the pointless name define and adds an id table.
It's not technically required in drivers with only one supported
part but it does make the probe code more consistent.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging:iio:resolver:ad2s90 fix registration of null pointer
Jonathan Cameron [Wed, 5 Oct 2011 14:27:56 +0000]
staging:iio:resolver:ad2s90 fix registration of null pointer

When the new allocation code was introduced a stray pointer
to iio_dev structure was left in the chip state structure.
This was never set but was then registered with the core.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging:iio:lisght:isl29018 use IIO_PROCESSED enum value.
Jonathan Cameron [Wed, 5 Oct 2011 14:27:55 +0000]
staging:iio:lisght:isl29018 use IIO_PROCESSED enum value.

No functional change, just a trivial tidy up so all drivers
do the same thing.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging:iio:adc:ad7314 removal. Supported via hwmon.
Jonathan Cameron [Wed, 5 Oct 2011 14:27:54 +0000]
staging:iio:adc:ad7314 removal. Supported via hwmon.

Driver ported over to hwmon where it fits much better.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: remove brcmf_op_if from fullmac
Franky Lin [Wed, 5 Oct 2011 13:20:14 +0000]
staging: brcm80211: remove brcmf_op_if from fullmac

Absorb related code into brcmf_add_if/brcmf_del_if. This is part
of the net device interface clean up.

Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: clean up struct brcmf_if in fullmac
Franky Lin [Wed, 5 Oct 2011 13:20:13 +0000]
staging: brcm80211: clean up struct brcmf_if in fullmac

Some elements in structure brcmf_if are unused at all or
redundant. This patch cleans it up.

Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: cleanup driver variable references
Arend van Spriel [Wed, 5 Oct 2011 13:20:12 +0000]
staging: brcm80211: cleanup driver variable references

Throughout the data structures within the driver several references
to the driver variables were stored. As the storage and access
functions are now consolidated into srom.c those references are
no longer needed and have been removed.

Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Alwin Beukers <alwin@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: remove parameter 'off' from _initvars_srom_pci()
Arend van Spriel [Wed, 5 Oct 2011 13:20:11 +0000]
staging: brcm80211: remove parameter 'off' from _initvars_srom_pci()

The function is called once with parameter 'off' fixed to zero. This
parameter has been removed.

Reviewed-by: Alwin Beukers <alwin@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: replace string based variable storage by linked list
Arend van Spriel [Wed, 5 Oct 2011 13:20:10 +0000]
staging: brcm80211: replace string based variable storage by linked list

The storage of variables obtained from srom are now stored in a linked
list and lookup is done based on the enumerated identifier.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Alwin Beukers <alwin@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: use enum identifiers in srom variable tables
Arend van Spriel [Wed, 5 Oct 2011 13:20:09 +0000]
staging: brcm80211: use enum identifiers in srom variable tables

In the srom variable tables fields were identified using string
identifiers. This has been replaced by enumeration identifiers.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Alwin Beukers <alwin@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: use identifiers instead of string for srom lookup
Arend van Spriel [Wed, 5 Oct 2011 13:20:08 +0000]
staging: brcm80211: use identifiers instead of string for srom lookup

The driver variables from srom are stored in memory with string
identifiers and the caller needed to use this string identifier
to retrieve a driver variable. The commit changes the calling
code replacing strings with enumerated identifiers.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Alwin Beukers <alwin@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: remove invalid variable lookup from srom
Arend van Spriel [Wed, 5 Oct 2011 13:20:07 +0000]
staging: brcm80211: remove invalid variable lookup from srom

In the driver several driver variables were looked up that are
not supported by the srom code. These have been removed.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Alwin Beukers <alwin@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: fix thread blocking issue in brcmf_sdbrcm_bus_stop()
Arend van Spriel [Wed, 5 Oct 2011 13:20:06 +0000]
staging: brcm80211: fix thread blocking issue in brcmf_sdbrcm_bus_stop()

The function brcmf_sdbrcm_bus_stop() terminates the watchdog and dpc
thread, but this function can be called from the dpc thread itself.
Stopping the dpc thread is only done when it is not the 'current'
thread.

Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: remove locking macro definitions
Arend van Spriel [Wed, 5 Oct 2011 13:20:05 +0000]
staging: brcm80211: remove locking macro definitions

The driver contained locking macros which map directly to the
lock function provided by the kernel. It does not provide any
additional value so these have been removed.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Alwin Beukers <alwin@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: change parameter in driver variable lookup
Arend van Spriel [Wed, 5 Oct 2011 13:20:04 +0000]
staging: brcm80211: change parameter in driver variable lookup

The functions getvar() and getintvar() had to pass the buffer
containing the driver variables. Now they pass the structure
containing this buffer hiding what type of buffer/container
is used for storing the driver variables.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Alwin Beukers <alwin@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: remove code duplication for driver variable lookup
Arend van Spriel [Wed, 5 Oct 2011 13:20:03 +0000]
staging: brcm80211: remove code duplication for driver variable lookup

The phy code used its own driver variable lookup functions which were
duplicates of those in the brcmsmac driver (in srom.c). The phy code
now uses the functions in srom.c through the phy_shim interface.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Alwin Beukers <alwin@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: remove redundant bus register layer from fullmac
Franky Lin [Wed, 5 Oct 2011 13:20:02 +0000]
staging: brcm80211: remove redundant bus register layer from fullmac

Remove some single line functions for bus register/unregister interface

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: remove threads_only code from fullmac
Franky Lin [Wed, 5 Oct 2011 13:20:01 +0000]
staging: brcm80211: remove threads_only code from fullmac

threads_only is always true as we never use the tasklet implementation.
So related code is removed.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: move driver variable functions to srom.c
Arend van Spriel [Wed, 5 Oct 2011 13:30:44 +0000]
staging: brcm80211: move driver variable functions to srom.c

The driver uses variables which are stored in string format. Using
strings as variable identifiers is disliked by the community. The
driver has been cleaned up and the only module providing these
variables is srom.c. The variable retrieval functions have been
moved to srom.c in preparation of a more likable way to store and
lookup these driver variables.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Alwin Beukers <alwin@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: smac: fix for 64 bit systems
Roland Vossen [Tue, 4 Oct 2011 21:19:12 +0000]
staging: brcm80211: smac: fix for 64 bit systems

A bug was introduced by the following commit (Sep 13):

    staging: brcm80211: use endian annotated structures in brcmsmac

Result was that 64 bits systems will not be able to acquire an IP address.
Also the rmmod crashed. This has been fixed and retested on a Sparc64.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Alwin Beukers <alwin@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: softmac: added event tracing
Roland Vossen [Tue, 4 Oct 2011 21:19:11 +0000]
staging: brcm80211: softmac: added event tracing

Dpc and timer events can now be traced. Combined with Mac80211
driver callback tracing, all entry points into the driver can now
be traced.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Alwin Beukers <alwin@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: remove N mode validation function
Alwin Beukers [Tue, 4 Oct 2011 21:19:10 +0000]
staging: brcm80211: remove N mode validation function

Removed the brcms_c_nmode_validate function as it only checks N-mode
capability, which should always be true.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: combined if statements
Alwin Beukers [Tue, 4 Oct 2011 21:19:09 +0000]
staging: brcm80211: combined if statements

Combined if statements in brcms_c_edcf_setparams and brcms_c_wme_setparams functions.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: remove brcms_b_dotxstatus wrapper function
Alwin Beukers [Tue, 4 Oct 2011 21:19:08 +0000]
staging: brcm80211: remove brcms_b_dotxstatus wrapper function

- removed brcms_b_dotxstatus
- changed 'fatal' argument of brcms_b_txstatus from INOUT to OUT.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: removed synchronisation of wlc->machwcap field
Alwin Beukers [Tue, 4 Oct 2011 21:19:07 +0000]
staging: brcm80211: removed synchronisation of wlc->machwcap field

- removed copying field wlc->machwcap from brcms_hardware to brcms_c_info
  during module attach.
- field wlc->machwcap was written but never read. Therefore it was removed.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: removed unneeded call to brcms_b_tx_fifo_suspended
Alwin Beukers [Tue, 4 Oct 2011 21:19:06 +0000]
staging: brcm80211: removed unneeded call to brcms_b_tx_fifo_suspended

- removed call to brcms_b_tx_fifo_suspended on receipt of TX FIFO suspend/flush
  completion signal.
- removed brcms_b_tx_fifo_suspended function as it is not being used elsewhere.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: cleanup of several wrapper functions
Alwin Beukers [Tue, 4 Oct 2011 21:19:05 +0000]
staging: brcm80211: cleanup of several wrapper functions

- removed brcms_c_write_template_ram function.
- removed brcms_c_mctrl function.
- removed brcms_c_pllreq function.
- removed brcms_c_mhf function.
- removed brcms_c_rate_shm_offset function.
- removed brcms_c_write_hw_bcntemplates function.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: cleanup of transmit buffer size related wrapper function
Alwin Beukers [Tue, 4 Oct 2011 21:19:04 +0000]
staging: brcm80211: cleanup of transmit buffer size related wrapper function

Removed brcms_c_xmtfifo_sz_get function.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: cleanup of shared memory related wrapper functions
Alwin Beukers [Tue, 4 Oct 2011 21:19:03 +0000]
staging: brcm80211: cleanup of shared memory related wrapper functions

- removed brcms_c_read_shm and brcms_c_write_shm functions.
- removed redundant argument check from brcms_c_copyto_shm function.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: removed redundant code from brcms_c_set_gmode
Alwin Beukers [Tue, 4 Oct 2011 21:19:02 +0000]
staging: brcm80211: removed redundant code from brcms_c_set_gmode

The comment says the rateset is being cleared when switching to GMODE_LEGACY_B,
but the code that follows it does not do so. Besides, the rateset is already
valid at this point.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: decreased indentation level of brcms_c_wme_setparams function
Alwin Beukers [Tue, 4 Oct 2011 21:19:01 +0000]
staging: brcm80211: decreased indentation level of brcms_c_wme_setparams function

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: removed empty brcms_c_reset_bmac_done callback function
Alwin Beukers [Tue, 4 Oct 2011 21:19:00 +0000]
staging: brcm80211: removed empty brcms_c_reset_bmac_done callback function

Empty functions are good candidates for removal.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: made NULL ethernet address const
Alwin Beukers [Tue, 4 Oct 2011 21:18:59 +0000]
staging: brcm80211: made NULL ethernet address const

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: fixed function returns
Alwin Beukers [Tue, 4 Oct 2011 21:18:58 +0000]
staging: brcm80211: fixed function returns

- removed unneeded return statements at end of functions.
- changed return value of brcms_c_radio_monitor_start to void.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: removed accessor functions for band type and etheraddress.
Alwin Beukers [Tue, 4 Oct 2011 21:18:57 +0000]
staging: brcm80211: removed accessor functions for band type and etheraddress.

Functions were trivial so not really adding value.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: fixed checkpatch warnings
Alwin Beukers [Tue, 4 Oct 2011 21:18:56 +0000]
staging: brcm80211: fixed checkpatch warnings

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: stop using assigned thread priority in fullmac
Franky Lin [Tue, 4 Oct 2011 21:18:55 +0000]
staging: brcm80211: stop using assigned thread priority in fullmac

Stop assigning priority to watchdog and dpc threads. Remove related
code.

Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: remove fullmac module_param for intr/poll mode
Franky Lin [Tue, 4 Oct 2011 21:18:54 +0000]
staging: brcm80211: remove fullmac module_param for intr/poll mode

Use constant for interrupt/polling mode configuration.

Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: clean up rtnl_lock in fullmac
Franky Lin [Tue, 4 Oct 2011 21:18:53 +0000]
staging: brcm80211: clean up rtnl_lock in fullmac

rtnl lock is used improperly in fullmac. This patch intends to clean
them up.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Sukesh Srikakula <sukeshs@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: fullmac: fixed double #include
Roland Vossen [Tue, 4 Oct 2011 21:18:52 +0000]
staging: brcm80211: fullmac: fixed double #include

Fix double include as detected by checkincludes script.

Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: replace brcmu_bitcount with hweight8
Arend van Spriel [Tue, 4 Oct 2011 21:18:51 +0000]
staging: brcm80211: replace brcmu_bitcount with hweight8

The kernel provides bit operations to replace brcmu_bitcount so
using those instead.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: remove brcmu_bprintf and related functions
Arend van Spriel [Tue, 4 Oct 2011 21:18:50 +0000]
staging: brcm80211: remove brcmu_bprintf and related functions

The functions brcmu_bprintf and brcmu_binit could be replaced by
snprintf kernel function. These are no longer used in both brcm80211
drivers so they have been removed.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: remove filtering of received frames
Arend van Spriel [Tue, 4 Oct 2011 21:18:49 +0000]
staging: brcm80211: remove filtering of received frames

In the receive path of the brcmsmac driver probe request frames and
frames with invalid mac address fields are dropped. This is only
fine for STA mode. Anticipating coming AP and monitor mode functionality
this is unwanted behavior.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: remove setting ssn to zero upon AMPDU_TX_START
Arend van Spriel [Tue, 4 Oct 2011 21:18:48 +0000]
staging: brcm80211: remove setting ssn to zero upon AMPDU_TX_START

The ssn should be given a valid value by the driver or it should not
override the value. Removed override to zero from the driver.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: cleaned up struct brcms_bss_cfg
Roland Vossen [Tue, 4 Oct 2011 21:18:47 +0000]
staging: brcm80211: cleaned up struct brcms_bss_cfg

Several fields were unused or were only set once. They have been
removed. Uncalled functions that relied on these constants have been
removed as well.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: et131x: Fix indefinite low power sleep
Mark Einon [Sat, 1 Oct 2011 10:14:17 +0000]
staging: et131x: Fix indefinite low power sleep

The mechanism by which the device is put into low power sleep is broken
in that the device can never come back out of low power mode afterwards.
Temorary fix to bring the device back out of sleep almost immediately,
until a suitable wake trigger can be found.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: et131x: Updating copyright statements and module authors
Mark Einon [Sat, 1 Oct 2011 10:14:16 +0000]
staging: et131x: Updating copyright statements and module authors

Adding copyright notices and adding myself as a module author.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: et131x: Update TODO file for kernel parameters
Mark Einon [Sat, 1 Oct 2011 10:14:15 +0000]
staging: et131x: Update TODO file for kernel parameters

set_mac is implemented, and there have been lots of new ethtool_ops added, so
removing the TODO to add more kernel parameters.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: et131x: Fix add_timer() from et131x_open
Mark Einon [Sat, 1 Oct 2011 10:14:14 +0000]
staging: et131x: Fix add_timer() from et131x_open

The error_timer was only getting initialised and an initial jiffies value set following a probe.
This could result in the timer needlessly expiring immediately after et131x_open is called.
Now this is all done from the open call instead.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: et131x: Add pci suspend & resume functions
Mark Einon [Sat, 1 Oct 2011 10:14:13 +0000]
staging: et131x: Add pci suspend & resume functions

Added basic suspend & resume functionality.
Tested on an et1310 device, and putting Fedora15 host in and out of
hibernation successfully.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: et131x: Remove adapter->bmsr, replace with phydev equivalents
Mark Einon [Sat, 1 Oct 2011 10:14:12 +0000]
staging: et131x: Remove adapter->bmsr, replace with phydev equivalents

adapter->bmsr is no longer being updated, but is also used to check the link state in places.

Remove bmsr from adapter, and replace link state checks with phydev->link check.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: et131x: Introduce et1310_in_phy_coma() call
Mark Einon [Sat, 1 Oct 2011 10:14:11 +0000]
staging: et131x: Introduce et1310_in_phy_coma() call

In several places in the code, the pm_csr register is read and the PHY_SW_COMA bit checked.

Move this check into its own small function to make the code more readable.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: et131x: Remove TODO entry 'alloc_etherdev initilising memory with zero'
Mark Einon [Sat, 1 Oct 2011 10:14:10 +0000]
staging: et131x: Remove TODO entry 'alloc_etherdev initilising memory with zero'

Removing this as I'm pretty sure its not true, and alloc_etherdev isn't provided by this driver anyway. Alternatively, its a badly written comment and I don't understand it.

This drivers use of alloc_etherdev() is within keeping with other net devices, so I'm happy.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: wlags49_h2: Remove bad debug message
David Kilroy [Sat, 1 Oct 2011 08:43:50 +0000]
staging: wlags49_h2: Remove bad debug message

The message is in the wrong place. We definitely don't want to
return at this point, as we may need to turn off encryption.

Reported-by: Henk de Groot <pe1dnn@amsat.org>
Signed-off-by: David Kiroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: wlags49_h2: Remove unused debug function
David Kilroy [Sat, 1 Oct 2011 08:43:49 +0000]
staging: wlags49_h2: Remove unused debug function

The function no longer compiles, so we just remove it.

Reported-by: Henk de Groot <pe1dnn@amsat.org>
Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: wlags49_h2: Use C99 __func__
David Kilroy [Sat, 1 Oct 2011 08:43:48 +0000]
staging: wlags49_h2: Use C99 __func__

in DBG machinery so you don't have to declare DBG_FUNC at
the start of all functions.

This just makes it easy to add DBG conforming to existing code.

The patch reformats the changed #defines to satisfy checkstyle.pl

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Get rid of unnecessary comments
K. Y. Srinivasan [Thu, 29 Sep 2011 18:55:04 +0000]
Staging: hv: mousevsc: Get rid of unnecessary comments

Get rid of unnecessary comments.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Enable autoloading of the mouse driver
K. Y. Srinivasan [Thu, 29 Sep 2011 18:55:03 +0000]
Staging: hv: mousevsc: Enable autoloading of the mouse driver

Now that the mouse driver is functional, enable the auto-loading of the driver.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Cleanup mousevsc_on_device_add()
K. Y. Srinivasan [Thu, 29 Sep 2011 18:55:02 +0000]
Staging: hv: mousevsc: Cleanup mousevsc_on_device_add()

Cleanup  mousevsc_on_device_add().

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Get rid of mousevsc_on_receive_input_report() by inlining
K. Y. Srinivasan [Thu, 29 Sep 2011 18:55:01 +0000]
Staging: hv: mousevsc: Get rid of mousevsc_on_receive_input_report() by inlining

Get rid of mousevsc_on_receive_input_report() by inlining the code.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Cleanup camel cased enums
K. Y. Srinivasan [Thu, 29 Sep 2011 18:55:00 +0000]
Staging: hv: mousevsc: Cleanup camel cased enums

Cleanup all camel cased names.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Get rid of ref_count state in struct mousevsc_dev
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:59 +0000]
Staging: hv: mousevsc: Get rid of ref_count state in struct mousevsc_dev

Now get rid of the machinery for managing the life-cycle of the mousevsc_dev
as this is not needed.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Now cleanup mousevsc_remove()
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:58 +0000]
Staging: hv: mousevsc: Now cleanup mousevsc_remove()

Now, cleanup mousevsc_remove(). The mouse driver once initialized only
receives data from the host. So, by closing the channel first in the
unload path, we can properly deal with inflight packets. So, we don't need
the machinery for managing the life-cycle of the mousevsc_dev object.
Get rid of the unnecessary code.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Get rid of mousevsc_on_device_remove() by inlining code
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:57 +0000]
Staging: hv: mousevsc: Get rid of mousevsc_on_device_remove() by inlining code

Get rid of mousevsc_on_device_remove() by inlining code.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Cleanup mousevsc_connect_to_vsp()
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:56 +0000]
Staging: hv: mousevsc: Cleanup mousevsc_connect_to_vsp()

Cleanup mousevsc_connect_to_vsp(). There is no need to take reference on the
mousevsc device object when we are setting up the device. As part of this
cleanup get rid of get_input_device() as this function is only used here.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Get rid of mousevsc_on_send_completion()
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:55 +0000]
Staging: hv: mousevsc: Get rid of mousevsc_on_send_completion()

We don't need to handle the "send complete" callback - nothing needs to be done
here; get rid of the code.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Cleanup alloc_input_device()
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:54 +0000]
Staging: hv: mousevsc: Cleanup alloc_input_device()

Cleanup alloc_input_device(); you can directly set the reference count.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Get rid of the unused state: num_outstanding_req
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:53 +0000]
Staging: hv: mousevsc: Get rid of the unused state: num_outstanding_req

Get rid of the unused state: num_outstanding_req in struct mousevsc_dev.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Free allocated memory in free_input_device()
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:52 +0000]
Staging: hv: mousevsc: Free allocated memory in free_input_device()

Free all allocated memory in free_input_device().

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Get rid of unnecessary pr_* calls
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:51 +0000]
Staging: hv: mousevsc: Get rid of unnecessary pr_* calls

Get rid of unnecessary pr_* calls.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Cleanup error handling
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:50 +0000]
Staging: hv: mousevsc: Cleanup error handling

Cleanup error handling in this driver; use standard Linux error codes.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Get rid of unnecessary DPRINT calls
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:49 +0000]
Staging: hv: mousevsc: Get rid of unnecessary DPRINT calls

Get rid of unnecessary DPRINT calls.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Cleanup and properly implement reportdesc_callback()
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:48 +0000]
Staging: hv: mousevsc: Cleanup and properly implement reportdesc_callback()

Cleanup and properly implement reportdesc_callback(); properly allocate the
hid_device and properly initialize the hid device structure.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Use completion primitive to synchronize
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:47 +0000]
Staging: hv: mousevsc: Use completion primitive to synchronize

Use completion primitive to synchronize.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Correctly initialize the header size
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:46 +0000]
Staging: hv: mousevsc: Correctly initialize the header size

Correctly initialize the header size.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Handle the case where we may get bogus report desc size
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:45 +0000]
Staging: hv: mousevsc: Handle the case where we may get bogus report desc size

Handle the case where we may get bogus report desc size from the host.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Change the allocation flags to reflect interrupt context
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:44 +0000]
Staging: hv: mousevsc: Change the allocation flags to reflect interrupt context

Change the allocation flags to reflect interrupt context.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Fixup some bogus WARN_ON() calls
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:43 +0000]
Staging: hv: mousevsc: Fixup some bogus WARN_ON() calls

Fix the bogus WARN_ON() calls.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Get rid of the struct input_device_context
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:42 +0000]
Staging: hv: mousevsc: Get rid of the struct input_device_context

The state maintained in struct input_device_context can easily be included
in the struct mousevsc_dev structure. Simplify the code by consolidating
the state.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agoStaging: hv: mousevsc: Fixup struct hv_input_dev_info
K. Y. Srinivasan [Thu, 29 Sep 2011 18:54:41 +0000]
Staging: hv: mousevsc: Fixup struct hv_input_dev_info

This structure is protocol defined structure and must match the definition
on the host side. Make appropriate adjustments.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: iio: if(__LITTLE_ENDIAN) -> #ifdef __LITTLE_ENDIAN
Jonathan Cameron [Tue, 4 Oct 2011 15:02:08 +0000]
staging: iio: if(__LITTLE_ENDIAN) -> #ifdef __LITTLE_ENDIAN

Unsuprisingly this symbol isn't defined on big endian systems.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: r8712u: include module.h where needed
Stephen Rothwell [Tue, 4 Oct 2011 07:32:57 +0000]
staging: r8712u: include module.h where needed

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: iio: adc: add includes of module.h and stat.h
Stephen Rothwell [Tue, 4 Oct 2011 07:21:11 +0000]
staging: iio: adc: add includes of module.h and stat.h

fixes these build problems:

drivers/staging/iio/adc/ad7746.c:345:8: error: 'S_IWUSR' undeclared here (not in a function)
drivers/staging/iio/adc/ad7746.c:436:8: error: 'S_IRUGO' undeclared here (not in a function)
drivers/staging/iio/adc/ad7746.c:681:19: error: 'THIS_MODULE' undeclared here (not in a function)
drivers/staging/iio/adc/ad7746.c:778:1: warning: data definition has no type or storage class [enabled by default]
drivers/staging/iio/adc/ad7746.c:778:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Wimplicit-int]
drivers/staging/iio/adc/ad7746.c:778:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/staging/iio/adc/ad7746.c:799:15: error: expected declaration specifiers or '...' before string constant
drivers/staging/iio/adc/ad7746.c:800:20: error: expected declaration specifiers or '...' before string constant
drivers/staging/iio/adc/ad7746.c:801:16: error: expected declaration specifiers or '...' before string constant

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8 years agostaging: brcm80211: removed functionality to disable N mode
Roland Vossen [Sun, 2 Oct 2011 17:14:45 +0000]
staging: brcm80211: removed functionality to disable N mode

NVRAM contains a parameter that can disable N mode. This functionality
is not needed. As a consequence, brcms_c_protection_upd() could be
simplified.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>