12 years ago[SCTP]: Annotate tsn_dups.
Al Viro [Tue, 21 Nov 2006 01:01:23 +0000]
[SCTP]: Annotate tsn_dups.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[SCTP]: SCTP_CMD_ASSOC_FAILED annotations.
Al Viro [Tue, 21 Nov 2006 01:01:06 +0000]
[SCTP]: SCTP_CMD_ASSOC_FAILED annotations.

also always get __be16 protocol error; switch to SCTP_PERR()

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[SCTP]: SCTP_CMD_INIT_FAILED annotations.
Al Viro [Tue, 21 Nov 2006 01:00:44 +0000]
[SCTP]: SCTP_CMD_INIT_FAILED annotations.

argument stored for SCTP_CMD_INIT_FAILED is always __be16
(protocol error).  Introduced new field and accessor for
it (SCTP_PERR()); switched to their use (from SCTP_U32() and
.u32)

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[SCTP]: sctp_stop_t1_and_abort() annotations.
Al Viro [Tue, 21 Nov 2006 01:00:25 +0000]
[SCTP]: sctp_stop_t1_and_abort() annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[SCTP]: sctp_make_op_error() annotations.
Al Viro [Tue, 21 Nov 2006 01:00:05 +0000]
[SCTP]: sctp_make_op_error() annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[SCTP]: Annotate sctp_init_cause().
Al Viro [Tue, 21 Nov 2006 00:59:45 +0000]
[SCTP]: Annotate sctp_init_cause().

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[SCTP]: Annotate SCTP headers.
Al Viro [Tue, 21 Nov 2006 00:59:12 +0000]
[SCTP]: Annotate SCTP headers.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[IPV6] net/ipv6/sit.c: make 2 functions static
Adrian Bunk [Tue, 21 Nov 2006 00:56:48 +0000]
[IPV6] net/ipv6/sit.c: make 2 functions static

This patch makes two needlessly global functions static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[XFRM]: Make copy_to_user_policy_type take a type
Jamal Hadi Salim [Tue, 21 Nov 2006 00:51:22 +0000]
[XFRM]: Make copy_to_user_policy_type take a type

Make copy_to_user_policy_type take a type instead a policy and
fix its users to pass the type

Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BRIDGE] netlink: Convert bridge netlink code to new netlink interface
Thomas Graf [Tue, 21 Nov 2006 00:20:22 +0000]
[BRIDGE] netlink: Convert bridge netlink code to new netlink interface

Removes dependency on buggy rta_buf, fixes a memory corruption bug due to
a unvalidated netlink attribute, and simplifies the code.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[DCCP]: Adds the tx buffer sysctls
Ian McDonald [Mon, 20 Nov 2006 21:19:32 +0000]
[DCCP]: Adds the tx buffer sysctls

This one got lost on the way from Ian to Gerrit to me, fix it.

Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[DCCP] CCID3: Remove non-referenced variable
Ian McDonald [Mon, 20 Nov 2006 20:44:03 +0000]
[DCCP] CCID3: Remove non-referenced variable

This removes a non-referenced variable.

Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[DCCP]: Update Documentation
Ian McDonald [Mon, 20 Nov 2006 20:42:45 +0000]
[DCCP]: Update Documentation

This patch just updates DCCP documentation a bit.

Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[DCCP]: Make dccp_probe more portable
Ian McDonald [Mon, 20 Nov 2006 20:41:37 +0000]
[DCCP]: Make dccp_probe more portable

This makes the code of the dccp_probe module more portable.

Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[CCID 3]: Add annotations for socket structures
Gerrit Renker [Mon, 20 Nov 2006 20:40:42 +0000]
[CCID 3]: Add annotations for socket structures

This adds documentation to the CCID 3 rx/tx socket fields, plus some
minor re-formatting.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[DCCP]: Simplified conditions due to use of enum:8 states
Gerrit Renker [Mon, 20 Nov 2006 20:39:23 +0000]
[DCCP]: Simplified conditions due to use of enum:8 states

This reaps the benefit of the earlier patch, which changed the type of
CCID 3 states to use enums, in that many conditions are now simplified
and the number of possible (unexpected) values is greatly reduced.

In a few instances, this also allowed to simplify pre-conditions; where
care has been taken to retain logical equivalence.

[DCCP]: Introduce a consistent BUG/WARN message scheme

This refines the existing set of DCCP messages so that
 * BUG(), BUG_ON(), WARN_ON() have meaningful DCCP-specific counterparts
 * DCCP_CRIT (for severe warnings) is not rate-limited
 * DCCP_WARN() is introduced as rate-limited wrapper

Using these allows a faster and cleaner transition to their original
counterparts once the code has matured into a full DCCP implementation.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[DCCP]: Set TX Queue Length Bounds via Sysctl
Ian McDonald [Mon, 20 Nov 2006 20:30:17 +0000]
[DCCP]: Set TX Queue Length Bounds via Sysctl

Previously the transmit queue was unbounded.

This patch:
* puts a limit on transmit queue length
  and sends back EAGAIN if the buffer is full
* sets the TX queue length to a sensible default
* implements tx buffer sysctls for DCCP

Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[DCCP]: Add CCID3 debug support to Kconfig
Gerrit Renker [Mon, 20 Nov 2006 20:28:09 +0000]
[DCCP]: Add CCID3 debug support to Kconfig

This adds a CCID3 debug option to the configuration menu
which is missing in Kconfig, but already used by the code.

CCID 2 already provides such an entry.

To enable debugging, set CONFIG_IP_DCCP_CCID3_DEBUG=y

NOTE: The use of ccid3_{t,r}x_state_name is safe, since
      now only enum values can appear.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[DCCP]: enable debug messages also for static builds
Gerrit Renker [Mon, 20 Nov 2006 20:26:03 +0000]
[DCCP]: enable debug messages also for static builds

This patch
  * makes debugging (when configured) work both for static / module build
  * provides generic debugging macros for use in other DCCP / CCID modules
  * adds missing information about debug parameters to Kconfig
  * performs some code tidy-up

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[BNX2]: Update version and rel date.
Michael Chan [Sun, 19 Nov 2006 22:15:31 +0000]
[BNX2]: Update version and rel date.

Update version to 1.5.1.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: Add 5709 PCI ID.
Michael Chan [Sun, 19 Nov 2006 22:15:05 +0000]
[BNX2]: Add 5709 PCI ID.

Add PCI ID and detection for 5709 copper and SerDes chips.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: Download 5709 firmware.
Michael Chan [Sun, 19 Nov 2006 22:14:35 +0000]
[BNX2]: Download 5709 firmware.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: New firmware to support 5709 (part 4).
Michael Chan [Sun, 19 Nov 2006 22:13:52 +0000]
[BNX2]: New firmware to support 5709 (part 4).

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: New firmware to support 5709 (part 3).
Michael Chan [Sun, 19 Nov 2006 22:13:23 +0000]
[BNX2]: New firmware to support 5709 (part 3).

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: New firmware to support 5709 (part 2).
Michael Chan [Sun, 19 Nov 2006 22:12:55 +0000]
[BNX2]: New firmware to support 5709 (part 2).

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: New firmware to support 5709 (part 1).
Michael Chan [Sun, 19 Nov 2006 22:12:28 +0000]
[BNX2]: New firmware to support 5709 (part 1).

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: Add 5709 reset and runtime code.
Michael Chan [Sun, 19 Nov 2006 22:11:41 +0000]
[BNX2]: Add 5709 reset and runtime code.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: Add 5709 init code.
Michael Chan [Sun, 19 Nov 2006 22:10:45 +0000]
[BNX2]: Add 5709 init code.

Add basic support to initialize the 5709 chip.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: Add new 5709 registers (part 2).
Michael Chan [Sun, 19 Nov 2006 22:10:12 +0000]
[BNX2]: Add new 5709 registers (part 2).

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: Add new 5709 registers (part 1).
Michael Chan [Sun, 19 Nov 2006 22:09:48 +0000]
[BNX2]: Add new 5709 registers (part 1).

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: Re-organize firmware structures.
Michael Chan [Sun, 19 Nov 2006 22:09:25 +0000]
[BNX2]: Re-organize firmware structures.

Re-organize the firmware handling code and declarations a bit to make
the code more compact.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: Remove udelay() in copper PHY code.
Michael Chan [Sun, 19 Nov 2006 22:08:56 +0000]
[BNX2]: Remove udelay() in copper PHY code.

Change a long udelay() in bnx2_setup_copper_phy() to msleep().

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: Add 5708S parallel detection.
Michael Chan [Sun, 19 Nov 2006 22:08:29 +0000]
[BNX2]: Add 5708S parallel detection.

Add code to parallel detect 1Gbps and 2.5Gbps link speeds.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: Add bnx2_5706_serdes_timer().
Michael Chan [Sun, 19 Nov 2006 22:08:00 +0000]
[BNX2]: Add bnx2_5706_serdes_timer().

Separate the 5706S SerDes handling code in bnx2_timer() and put it
in a new function.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: Improve SerDes handling.
Michael Chan [Sun, 19 Nov 2006 22:07:28 +0000]
[BNX2]: Improve SerDes handling.

1. Add support for 2.5Gbps forced speed setting.
2. Remove a long udelay() loop and change to msleep().
3. Other misc. SerDes fixes.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[BNX2]: Fix Xen problem.
Michael Chan [Sun, 19 Nov 2006 22:06:40 +0000]
[BNX2]: Fix Xen problem.

This fixes the problem of not receiving packets in the Xen bridging
environment.  The Xen script sets the device's MAC address to
FE:FF:FF:FF:FF:FF and puts the device in promiscuous mode.  The
firmware had problem receiving all packets in this configuration.

New firmware and setting the PROM_VLAN bit when in promiscuous mode
will fix this problem.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years agoCompile fix for "peer secid consolidation for external network labeling"
James Morris [Sat, 18 Nov 2006 04:01:03 +0000]
Compile fix for "peer secid consolidation for external network labeling"

Use a forward declaration instead of dragging in skbuff.h and
related junk.

Signed-off-by: James Morris <jmorris@namei.org>

12 years agoNetLabel: honor the audit_enabled flag
Paul Moore [Fri, 17 Nov 2006 22:38:55 +0000]
NetLabel: honor the audit_enabled flag

The audit_enabled flag is used to signal when syscall auditing is to be
performed.  While NetLabel uses a Netlink interface instead of syscalls, it is
reasonable to consider the NetLabel Netlink interface as a form of syscall so
pay attention to the audit_enabled flag when generating audit messages in
NetLabel.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

12 years agoSELinux: peer secid consolidation for external network labeling
Paul Moore [Fri, 17 Nov 2006 22:38:54 +0000]
SELinux: peer secid consolidation for external network labeling

Now that labeled IPsec makes use of the peer_sid field in the
sk_security_struct we can remove a lot of the special cases between labeled
IPsec and NetLabel.  In addition, create a new function,
security_skb_extlbl_sid(), which we can use in several places to get the
security context of the packet's external label which allows us to further
simplify the code in a few places.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

12 years agoNetLabel: SELinux cleanups
Paul Moore [Fri, 17 Nov 2006 22:38:53 +0000]
NetLabel: SELinux cleanups

This patch does a lot of cleanup in the SELinux NetLabel support code.  A
summary of the changes include:

* Use RCU locking for the NetLabel state variable in the skk_security_struct
  instead of using the inode_security_struct mutex.
* Remove unnecessary parameters in selinux_netlbl_socket_post_create().
* Rename selinux_netlbl_sk_clone_security() to
  selinux_netlbl_sk_security_clone() to better fit the other NetLabel
  sk_security functions.
* Improvements to selinux_netlbl_inode_permission() to help reduce the cost of
  the common case.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

12 years agoNetLabel: use cipso_v4_doi_search() for local CIPSOv4 functions
Paul Moore [Fri, 17 Nov 2006 22:38:52 +0000]
NetLabel: use cipso_v4_doi_search() for local CIPSOv4 functions

The cipso_v4_doi_search() function behaves the same as cipso_v4_doi_getdef()
but is a local, static function so use it whenever possibile in the CIPSOv4
code base.

Signed-of-by: Paul Moore <paul.moore@hp.com>

Signed-off-by: James Morris <jmorris@namei.org>

12 years agoNetLabel: use the correct CIPSOv4 MLS label limits
Paul Moore [Fri, 17 Nov 2006 22:38:51 +0000]
NetLabel: use the correct CIPSOv4 MLS label limits

The CIPSOv4 engine currently has MLS label limits which are slightly larger
than what the draft allows.  This is not a major problem due to the current
implementation but we should fix this so it doesn't bite us later.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

12 years agoNetLabel: return the correct error for translated CIPSOv4 tags
Paul Moore [Fri, 17 Nov 2006 22:38:50 +0000]
NetLabel: return the correct error for translated CIPSOv4 tags

The CIPSOv4 translated tag #1 mapping does not always return the correct error
code if the desired mapping does not exist; instead of returning -EPERM it
returns -ENOSPC indicating that the buffer is not large enough to hold the
translated value.  This was caused by failing to check a specific error
condition.  This patch fixes this so that unknown mappings return
-EPERM which is consistent with the rest of the related CIPSOv4 code.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

12 years agoNetLabel: fixup the handling of CIPSOv4 tags to allow for multiple tag types
Paul Moore [Fri, 17 Nov 2006 22:38:49 +0000]
NetLabel: fixup the handling of CIPSOv4 tags to allow for multiple tag types

While the original CIPSOv4 code had provisions for multiple tag types the
implementation was not as great as it could be, pushing a lot of non-tag
specific processing into the tag specific code blocks.  This patch fixes that
issue making it easier to support multiple tag types in the future.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

12 years agoNetLabel: add tag verification when adding new CIPSOv4 DOI definitions
Paul Moore [Fri, 17 Nov 2006 22:38:48 +0000]
NetLabel: add tag verification when adding new CIPSOv4 DOI definitions

Currently the CIPSOv4 engine does not do any sort of checking when a new DOI
definition is added.  The tags are still verified but only as a side effect of
normal NetLabel operation (packet processing, socket labeling, etc.) which
would cause application errors due to the faulty configuration.  This patch
adds tag checking when new DOI definition are added allowing us to catch these
configuration problems when they happen.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

12 years agoNetLabel: check for a CIPSOv4 option before we do call into the CIPSOv4 layer
Paul Moore [Fri, 17 Nov 2006 22:38:47 +0000]
NetLabel: check for a CIPSOv4 option before we do call into the CIPSOv4 layer

Right now the NetLabel code always jumps into the CIPSOv4 layer to determine if
a CIPSO IP option is present.  However, we can do this check directly in the
NetLabel code by making use of the CIPSO_V4_OPTEXIST() macro which should save
us a function call in the common case of not having a CIPSOv4 option present.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

12 years agoNetLabel: make netlbl_lsm_secattr struct easier/quicker to understand
Paul Moore [Fri, 17 Nov 2006 22:38:46 +0000]
NetLabel: make netlbl_lsm_secattr struct easier/quicker to understand

The existing netlbl_lsm_secattr struct required the LSM to check all of the
fields to determine if any security attributes were present resulting in a lot
of work in the common case of no attributes.  This patch adds a 'flags' field
which is used to indicate which attributes are present in the structure; this
should allow the LSM to do a quick comparison to determine if the structure
holds any security attributes.

Example:

 if (netlbl_lsm_secattr->flags)
/* security attributes present */
 else
/* NO security attributes present */

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

12 years agoNetLabel: change netlbl_secattr_init() to return void
Paul Moore [Fri, 17 Nov 2006 22:38:45 +0000]
NetLabel: change netlbl_secattr_init() to return void

The netlbl_secattr_init() function would always return 0 making it pointless
to have a return value.  This patch changes the function to return void.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

12 years agoNetLabel: convert the unlabeled accept flag to use RCU
Paul Moore [Fri, 17 Nov 2006 22:38:44 +0000]
NetLabel: convert the unlabeled accept flag to use RCU

Currently the NetLabel unlabeled packet accept flag is an atomic type and it
is checked for every non-NetLabel packet which comes into the system but rarely
ever changed.  This patch changes this flag to a normal integer and protects it
with RCU locking.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

12 years agoNetLabel: use gfp_t instead of int where it makes sense
Paul Moore [Fri, 17 Nov 2006 22:38:43 +0000]
NetLabel: use gfp_t instead of int where it makes sense

There were a few places in the NetLabel code where the int type was being used
instead of the gfp_t type, this patch corrects this mistake.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

12 years ago[TCP]: Tidy up skb_entail
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 21:59:12 +0000]
[TCP]: Tidy up skb_entail

Heck, it even saves us some few bytes:

[acme@newtoy net-2.6.20]$ codiff -f /tmp/tcp.o.before ../OUTPUT/qemu/net-2.6.20/net/ipv4/tcp.o
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/tcp.c:
  tcp_sendpage |   -7
  tcp_sendmsg  |   -5
 2 functions changed, 12 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[NETROM]: Use kmemdup
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 15:05:04 +0000]
[NETROM]: Use kmemdup

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[AX25]: Use kmemdup
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 14:43:07 +0000]
[AX25]: Use kmemdup

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/ax25.ko.before /tmp/ax25.ko.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ax25/ax25_out.c:
  ax25_send_frame |   -8
 1 function changed, 8 bytes removed

/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ax25/ax25_route.c:
  ax25_rt_autobind |  -15
 1 function changed, 15 bytes removed

/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ax25/af_ax25.c:
  ax25_make_new |  -33
 1 function changed, 33 bytes removed

/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ax25/sysctl_net_ax25.c:
  ax25_register_sysctl |  -21
 1 function changed, 21 bytes removed

/tmp/ax25.ko.after:
 4 functions changed, 77 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[DECNET]: Use kmemdup
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 14:29:21 +0000]
[DECNET]: Use kmemdup

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/decnet.ko.before /tmp/decnet.ko.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/decnet/dn_dev.c:
  dn_dev_sysctl_register |  -51
 1 function changed, 51 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[DCCP]: Use kmemdup
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 14:21:43 +0000]
[DCCP]: Use kmemdup

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/dccp.ko.before /tmp/dccp.ko.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/dccp/feat.c:
  __dccp_feat_init      |  -16
  dccp_feat_change_recv |  -55
  dccp_feat_clone       |  -56
 3 functions changed, 127 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[IPV6]: Use kmemdup
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 14:14:37 +0000]
[IPV6]: Use kmemdup

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/ipv6.ko.before /tmp/ipv6.ko.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv6/ip6_output.c:
  ip6_output      |  -52
  ip6_append_data |   +2
 2 functions changed, 2 bytes added, 52 bytes removed

/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv6/addrconf.c:
  addrconf_sysctl_register |  -27
 1 function changed, 27 bytes removed

/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv6/tcp_ipv6.c:
  tcp_v6_syn_recv_sock  |  -32
  tcp_v6_parse_md5_keys |  -24
 2 functions changed, 56 bytes removed

/tmp/ipv6.ko.after:
 5 functions changed, 2 bytes added, 135 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[TCP] minisocks: Use kmemdup and LIMIT_NETDEBUG
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 13:25:49 +0000]
[TCP] minisocks: Use kmemdup and LIMIT_NETDEBUG

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/tcp_minisocks.o.before /tmp/tcp_minisocks.o.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/tcp_minisocks.c:
  tcp_check_req |  -44
 1 function changed, 44 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[IPV4]: Use kmemdup in net/ipv4/devinet.c
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 13:18:20 +0000]
[IPV4]: Use kmemdup in net/ipv4/devinet.c

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/devinet.o.before /tmp/devinet.o.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/devinet.c:
  devinet_sysctl_register |  -38
 1 function changed, 38 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[NETLABEL]: Use kmemdup in cipso_ipv4.c
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 13:14:16 +0000]
[NETLABEL]: Use kmemdup in cipso_ipv4.c

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/cipso_ipv4.o.before /tmp/cipso_ipv4.o.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/cipso_ipv4.c:
  cipso_v4_cache_add |  -46
 1 function changed, 46 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[TCP_IPV4]: Use kmemdup where appropriate
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 13:06:01 +0000]
[TCP_IPV4]: Use kmemdup where appropriate

Also use a variable to avoid the longish tp->md5sig_info-> use
in tcp_v4_md5_do_add.

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/tcp_ipv4.o.before /tmp/tcp_ipv4.o.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/tcp_ipv4.c:
  tcp_v4_md5_do_add     |  -62
  tcp_v4_syn_recv_sock  |  -32
  tcp_v4_parse_md5_keys |  -86
 3 functions changed, 180 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[TCP_IPV4]: CodingStyle cleanups, no code change
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 12:57:30 +0000]
[TCP_IPV4]: CodingStyle cleanups, no code change

Mostly related to CONFIG_TCP_MD5SIG recent merge.

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[DCCP] CCID2: Code optimizations
Andrea Bittau [Thu, 16 Nov 2006 16:28:40 +0000]
[DCCP] CCID2: Code optimizations

These are code optimizations which are relevant when dealing with large
windows.  They are not coded the way I would like to, but they do the job for
the short-term.  This patch should be more neat.

Commiter note: Changed the seqno comparisions to use {after,before}48 to handle
               wrapping.

Signed-off-by: Andrea Bittau <a.bittau@cs.ucl.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[NET]: Conditionally use bh_lock_sock_nested in sk_receive_skb
Arnaldo Carvalho de Melo [Thu, 16 Nov 2006 16:06:06 +0000]
[NET]: Conditionally use bh_lock_sock_nested in sk_receive_skb

Spotted by Ian McDonald, tentatively fixed by Gerrit Renker:

http://www.mail-archive.com/dccp%40vger.kernel.org/msg00599.html

Rewritten not to unroll sk_receive_skb, in the common case, i.e. no lock
debugging, its optimized away.

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[DCCP]: One NET_INC_STATS() could be NET_INC_STATS_BH in dccp_v4_err()
Arnaldo Carvalho de Melo [Thu, 16 Nov 2006 14:23:58 +0000]
[DCCP]: One NET_INC_STATS() could be NET_INC_STATS_BH in dccp_v4_err()

Spotted by Eric Dumazet in tcp_v4_rcv().

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[DCCP]: Introduce DCCP_{BUG{_ON},CRIT} macros, use enum:8 for the ccid3 states
Gerrit Renker [Wed, 15 Nov 2006 23:27:47 +0000]
[DCCP]: Introduce DCCP_{BUG{_ON},CRIT} macros, use enum:8 for the ccid3 states

This patch tackles the following problem:
       * the ccid3_hc_{t,r}x_sock define ccid3hc{t,r}x_state as `u8', but
         in reality there can only be a few, pre-defined enum names
       * this necessitates addiditional checking for unexpected values
         which would otherwise be caught by the compiler

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

12 years ago[UDPLite]: udplite.h needs ip6_checksum.h
David S. Miller [Wed, 15 Nov 2006 09:09:32 +0000]
[UDPLite]: udplite.h needs ip6_checksum.h

Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET/IPv4]: Make udp_push_pending_frames static
Gerrit Renker [Wed, 15 Nov 2006 08:44:49 +0000]
[NET/IPv4]: Make udp_push_pending_frames static

udp_push_pending_frames is only referenced within
net/ipv4/udp.c and hence can remain static.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[IPV6]: udp.c build fix
David S. Miller [Wed, 15 Nov 2006 06:09:20 +0000]
[IPV6]: udp.c build fix

Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: More dccp endianness annotations.
Al Viro [Wed, 15 Nov 2006 05:51:36 +0000]
[NET]: More dccp endianness annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: Preliminaty annotation of skb->csum.
Al Viro [Wed, 15 Nov 2006 05:44:08 +0000]
[NET]: Preliminaty annotation of skb->csum.

It's still not completely right; we need to split it into anon unions
of __wsum and unsigned - for cases when we use it for partial checksum
and for offset of checksum in skb

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET] driver/s390/net: Checksum annotations.
Al Viro [Wed, 15 Nov 2006 05:43:44 +0000]
[NET] driver/s390/net: Checksum annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: netfilter checksum annotations
Al Viro [Wed, 15 Nov 2006 05:43:23 +0000]
[NET]: netfilter checksum annotations

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: ipvs checksum annotations.
Al Viro [Thu, 16 Nov 2006 10:41:18 +0000]
[NET]: ipvs checksum annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: IP header modifier helpers annotations.
Al Viro [Wed, 15 Nov 2006 05:42:26 +0000]
[NET]: IP header modifier helpers annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: Make mangling a checksum (0 -> 0xffff on the wire) explicit.
Al Viro [Thu, 16 Nov 2006 10:36:50 +0000]
[NET]: Make mangling a checksum (0 -> 0xffff on the wire) explicit.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: Annotate __skb_checksum_complete() and friends.
Al Viro [Wed, 15 Nov 2006 05:40:42 +0000]
[NET]: Annotate __skb_checksum_complete() and friends.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: Annotate ip_vs_checksum_complete() and callers.
Al Viro [Wed, 15 Nov 2006 05:37:50 +0000]
[NET]: Annotate ip_vs_checksum_complete() and callers.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: Annotate skb_copy_and_csum_bits() and callers.
Al Viro [Wed, 15 Nov 2006 05:37:33 +0000]
[NET]: Annotate skb_copy_and_csum_bits() and callers.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: Annotate skb_checksum() and callers.
Al Viro [Wed, 15 Nov 2006 05:37:14 +0000]
[NET]: Annotate skb_checksum() and callers.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: Annotate callers of the reset of checksum.h stuff.
Al Viro [Wed, 15 Nov 2006 05:36:54 +0000]
[NET]: Annotate callers of the reset of checksum.h stuff.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: Annotate callers of csum_partial_copy_...() and csum_and_copy...() in net/*
Al Viro [Wed, 15 Nov 2006 05:36:34 +0000]
[NET]: Annotate callers of csum_partial_copy_...() and csum_and_copy...() in net/*

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: Annotate csum_partial() callers in net/*
Al Viro [Wed, 15 Nov 2006 05:36:14 +0000]
[NET]: Annotate csum_partial() callers in net/*

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: annotate csum_ipv6_magic() callers in net/*
Al Viro [Wed, 15 Nov 2006 05:35:48 +0000]
[NET]: annotate csum_ipv6_magic() callers in net/*

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: Annotate csum_tcpudp_magic() callers in net/*
Al Viro [Wed, 15 Nov 2006 05:28:51 +0000]
[NET]: Annotate csum_tcpudp_magic() callers in net/*

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: Annotate csum_tcpudp_magic() callers in net/*
Al Viro [Wed, 15 Nov 2006 05:28:24 +0000]
[NET]: Annotate csum_tcpudp_magic() callers in net/*

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: Annotate callers of csum_tcpudp_nofold() in net/*
Al Viro [Wed, 15 Nov 2006 05:26:08 +0000]
[NET]: Annotate callers of csum_tcpudp_nofold() in net/*

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: Annotate callers of csum_fold() in net/*
Al Viro [Wed, 15 Nov 2006 05:24:49 +0000]
[NET]: Annotate callers of csum_fold() in net/*

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: Annotate checksums in on-the-wire packets.
Al Viro [Wed, 15 Nov 2006 05:24:30 +0000]
[NET]: Annotate checksums in on-the-wire packets.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: Generic checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:23:59 +0000]
[NET]: Generic checksum annotations and cleanups.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: XTENSA checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:23:40 +0000]
[NET]: XTENSA checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill csum_partial_copy_fromuser
* kill csum_partial_copy
* kill useless shifts
* usual ntohs->shift

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: SPARC64 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:23:20 +0000]
[NET]: SPARC64 checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill useless shift

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: SPARC checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:22:56 +0000]
[NET]: SPARC checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill bogus access_ok() in csum_partial_copy_from_user (the only caller checks)
* kill useless shift

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: SH checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:22:35 +0000]
[NET]: SH checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill useless shifts
* usual ntohs->shift

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: S390 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:22:18 +0000]
[NET]: S390 checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill useless shifts

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: POWERPC checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:21:58 +0000]
[NET]: POWERPC checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill useless shifts

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: I386 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:21:37 +0000]
[NET]: I386 checksum annotations and cleanups.

* sanitize prototypes, annotate
* usual ntohs->shift

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: AVR32 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:21:15 +0000]
[NET]: AVR32 checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill useless shifts
* kill useless ntohs (it's big-endian, for fsck sake!)

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: ARM26 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:20:51 +0000]
[NET]: ARM26 checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill csum_partial_copy

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: ARM checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:20:28 +0000]
[NET]: ARM checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill csum_partial_copy
* usual ntohs->shift, this time in assembler part

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

12 years ago[NET]: X86_64 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:20:08 +0000]
[NET]: X86_64 checksum annotations and cleanups.

* sanitize prototypes, annotate
* usual ntohs->shift

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>