mac80211: make conf_tx non-atomic
Johannes Berg [Mon, 8 Sep 2008 09:05:09 +0000 (11:05 +0200)]
The conf_tx callback currently needs to be atomic, this requirement
is just because it can be called from scanning. This rearranges it
slightly to only update while not scanning (which is fine, we'll be
getting beacons when associated) and thus removes the atomic
requirement.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

include/net/mac80211.h
net/mac80211/mlme.c

index 7c399a9..fb9e622 100644 (file)
@@ -1142,7 +1142,7 @@ enum ieee80211_ampdu_mlme_action {
  *     of assocaited station or AP.
  *
  * @conf_tx: Configure TX queue parameters (EDCF (aifs, cw_min, cw_max),
- *     bursting) for a hardware TX queue. Must be atomic.
+ *     bursting) for a hardware TX queue.
  *
  * @get_tx_stats: Get statistics of the current TX queue status. This is used
  *     to get number of currently queued packets (queue length), maximum queue
index 0abd5a4..a032452 100644 (file)
@@ -2872,15 +2872,18 @@ static void ieee80211_rx_mgmt_beacon(struct ieee80211_sub_if_data *sdata,
            memcmp(ifsta->bssid, mgmt->bssid, ETH_ALEN) != 0)
                return;
 
-       ieee80211_sta_wmm_params(local, ifsta, elems.wmm_param,
-                                elems.wmm_param_len);
-
        /* Do not send changes to driver if we are scanning. This removes
-        * requirement that driver's bss_info_changed function needs to be
-        * atomic. */
+        * requirement that a driver's bss_info_changed/conf_tx functions
+        * need to be atomic.
+        * This is really ugly code, we should rewrite scanning and make
+        * all this more understandable for humans.
+        */
        if (local->sta_sw_scanning || local->sta_hw_scanning)
                return;
 
+       ieee80211_sta_wmm_params(local, ifsta, elems.wmm_param,
+                                elems.wmm_param_len);
+
        if (elems.erp_info && elems.erp_info_len >= 1)
                changed |= ieee80211_handle_erp_ie(sdata, elems.erp_info[0]);
        else {