perf session: Move full_paths config to symbol_conf
Arnaldo Carvalho de Melo [Sun, 27 Dec 2009 23:37:04 +0000 (21:37 -0200)]
Now perf_event_ops has just that, event handlers.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1261957026-15580-8-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

tools/perf/builtin-diff.c
tools/perf/builtin-report.c
tools/perf/util/session.c
tools/perf/util/session.h
tools/perf/util/symbol.h

index bd71b8c..e164b3d 100644 (file)
@@ -204,7 +204,7 @@ static const struct option options[] = {
        OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
        OPT_BOOLEAN('m', "modules", &symbol_conf.use_modules,
                    "load module symbols - WARNING: use only with -k and LIVE kernel"),
-       OPT_BOOLEAN('P', "full-paths", &event_ops.full_paths,
+       OPT_BOOLEAN('P', "full-paths", &symbol_conf.full_paths,
                    "Don't shorten the pathnames taking into account the cwd"),
        OPT_STRING('d', "dsos", &symbol_conf.dso_list_str, "dso[,dso...]",
                   "only consider symbols in these dsos"),
index 0825918..f695084 100644 (file)
@@ -321,7 +321,7 @@ static const struct option options[] = {
                   "pretty printing style key: normal raw"),
        OPT_STRING('s', "sort", &sort_order, "key[,key2...]",
                   "sort by key(s): pid, comm, dso, symbol, parent"),
-       OPT_BOOLEAN('P', "full-paths", &event_ops.full_paths,
+       OPT_BOOLEAN('P', "full-paths", &symbol_conf.full_paths,
                    "Don't shorten the pathnames taking into account the cwd"),
        OPT_STRING('p', "parent", &parent_pattern, "regex",
                   "regex filter to identify parent, see: '--sort parent'"),
index 4ca427f..4f2eeb5 100644 (file)
@@ -306,7 +306,7 @@ int perf_session__process_events(struct perf_session *self,
 
        head = self->header.data_offset;
 
-       if (!ops->full_paths) {
+       if (!symbol_conf.full_paths) {
                char bf[PATH_MAX];
 
                if (getcwd(bf, sizeof(bf)) == NULL) {
index 585937b..2ff77fe 100644 (file)
@@ -41,7 +41,6 @@ struct perf_event_ops {
        event_op        process_read_event;
        event_op        process_throttle_event;
        event_op        process_unthrottle_event;
-       bool            full_paths;
 };
 
 struct perf_session *perf_session__new(const char *filename, int mode, bool force);
index 8aded23..9eabd60 100644 (file)
@@ -58,7 +58,8 @@ struct symbol_conf {
                        sort_by_name,
                        show_nr_samples,
                        use_callchain,
-                       exclude_other;
+                       exclude_other,
+                       full_paths;
        const char      *vmlinux_name,
                        *field_sep;
        char            *dso_list_str,