appletalk/ddp.c: Neaten checksum function
Joe Perches [Wed, 4 Nov 2009 10:26:13 +0000 (10:26 +0000)]
atalk_sum_partial can now use the rol16 function in bitops.h

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

net/appletalk/ddp.c

index 31fca64..b631cc7 100644 (file)
@@ -922,13 +922,8 @@ static unsigned long atalk_sum_partial(const unsigned char *data,
 {
        /* This ought to be unwrapped neatly. I'll trust gcc for now */
        while (len--) {
-               sum += *data;
-               sum <<= 1;
-               if (sum & 0x10000) {
-                       sum++;
-                       sum &= 0xffff;
-               }
-               data++;
+               sum += *data++;
+               sum = rol16(sum, 1);
        }
        return sum;
 }