]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
ext4: missing unlock in ext4_clear_request_list()
authorDan Carpenter <error27@gmail.com>
Thu, 18 Nov 2010 02:46:25 +0000 (21:46 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 18 Nov 2010 02:46:25 +0000 (21:46 -0500)
If the the li_request_list was empty then it returned with the lock
held.  Instead of adding a "goto unlock" I just removed that special
case and let it go past the empty list_for_each_safe().

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/super.c

index 61182fe6254e94ad606a6c67fed1b30ef289ad38..ef09d1443d1aa649591bce83821d5dbea34091f3 100644 (file)
@@ -2799,9 +2799,6 @@ static void ext4_clear_request_list(void)
        struct ext4_li_request *elr;
 
        mutex_lock(&ext4_li_info->li_list_mtx);
-       if (list_empty(&ext4_li_info->li_request_list))
-               return;
-
        list_for_each_safe(pos, n, &ext4_li_info->li_request_list) {
                elr = list_entry(pos, struct ext4_li_request,
                                 lr_request);