ALSA: sound/aoa: Add kmalloc NULL tests
Julia Lawall [Fri, 31 Jul 2009 06:32:03 +0000 (08:32 +0200)]
Check that the result of kzalloc is not NULL before a dereference.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression *x;
identifier f;
constant char *C;
@@

x = \(kmalloc\|kcalloc\|kzalloc\)(...);
... when != x == NULL
    when != x != NULL
    when != (x || ...)
(
kfree(x)
|
f(...,C,...,x,...)
|
*f(...,x,...)
|
*x->f
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

sound/aoa/core/gpio-pmf.c

index 5ca2220..1dd0c28 100644 (file)
@@ -182,6 +182,10 @@ static int pmf_set_notify(struct gpio_runtime *rt,
        if (!old && notify) {
                irq_client = kzalloc(sizeof(struct pmf_irq_client),
                                     GFP_KERNEL);
+               if (!irq_client) {
+                       err = -ENOMEM;
+                       goto out_unlock;
+               }
                irq_client->data = notif;
                irq_client->handler = pmf_handle_notify_irq;
                irq_client->owner = THIS_MODULE;