perf tools: Add prelink suggestion to dso update message
David Ahern [Wed, 19 Oct 2011 00:44:45 +0000 (18:44 -0600)]
Following a prelink run mapped files for long running processes can show
as deleted. The current message suggests restarting long running
processes. Add to that a suggestion that prelink might be the cause.

Old message:
/lib64/libc-2.14.so was updated, restart the long running
 apps that use it!

New message:
/lib64/libc-2.14.so was updated (is prelink enabled?).
  Restart the long running apps that use it!

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1318985085-20776-1-git-send-email-dsahern@gmail.com
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

tools/perf/util/map.c

index 9cf0d43..78284b1 100644 (file)
@@ -139,8 +139,8 @@ int map__load(struct map *self, symbol_filter_t filter)
 
                if (len > sizeof(DSO__DELETED) &&
                    strcmp(name + real_len + 1, DSO__DELETED) == 0) {
-                       pr_warning("%.*s was updated, restart the long "
-                                  "running apps that use it!\n",
+                       pr_warning("%.*s was updated (is prelink enabled?). "
+                               "Restart the long running apps that use it!\n",
                                   (int)real_len, name);
                } else {
                        pr_warning("no symbols found in %s, maybe install "