[PATCH] mv643xx_eth: Fix misplaced parenthesis in mv643xx_eth_port_disable_rx
Dale Farnsworth [Fri, 3 Mar 2006 16:59:28 +0000 (09:59 -0700)]
This bug could result in a system hang.

Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

drivers/net/mv643xx_eth.c

index 4f36489..4cbf840 100644 (file)
@@ -2496,8 +2496,8 @@ static unsigned int mv643xx_eth_port_disable_rx(unsigned int port_num)
        u32 channels;
 
        /* Stop Rx port activity. Check port Rx activity. */
-       channels = mv_read(MV643XX_ETH_RECEIVE_QUEUE_COMMAND_REG(port_num)
-                                                       & 0xFF);
+       channels = mv_read(MV643XX_ETH_RECEIVE_QUEUE_COMMAND_REG(port_num))
+                                                       & 0xFF;
        if (channels) {
                /* Issue stop command for active channels only */
                mv_write(MV643XX_ETH_RECEIVE_QUEUE_COMMAND_REG(port_num),