PCI: aerdrv: remove magical ROOT_ERR_STATUS_MASKS
Hidetoshi Seto [Thu, 15 Apr 2010 04:18:26 +0000 (13:18 +0900)]
Make it clear that we only interest in 2 *_RCV bits.

Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Reviewed-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

drivers/pci/pcie/aer/aerdrv.c
drivers/pci/pcie/aer/aerdrv.h

index 1a55c16..cbc7cc7 100644 (file)
@@ -204,7 +204,7 @@ irqreturn_t aer_irq(int irq, void *context)
 
        /* Read error status */
        pci_read_config_dword(pdev->port, pos + PCI_ERR_ROOT_STATUS, &status);
-       if (!(status & ROOT_ERR_STATUS_MASKS)) {
+       if (!(status & (PCI_ERR_ROOT_UNCOR_RCV|PCI_ERR_ROOT_COR_RCV))) {
                spin_unlock_irqrestore(&rpc->e_lock, flags);
                return IRQ_NONE;
        }
index 2f34540..d0f8291 100644 (file)
@@ -17,9 +17,6 @@
 #define AER_FATAL                      1
 #define AER_CORRECTABLE                        2
 
-/* Root Error Status Register Bits */
-#define ROOT_ERR_STATUS_MASKS          0x0f
-
 #define SYSTEM_ERROR_INTR_ON_MESG_MASK (PCI_EXP_RTCTL_SECEE|   \
                                        PCI_EXP_RTCTL_SENFEE|   \
                                        PCI_EXP_RTCTL_SEFEE)