[SCSI] libsas: convert dev->gone to flags
Dan Williams [Sat, 7 Jan 2012 08:52:39 +0000 (08:52 +0000)]
In preparation for adding tracking of another device state "destroy".

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

drivers/scsi/libsas/sas_ata.c
drivers/scsi/libsas/sas_expander.c
drivers/scsi/libsas/sas_port.c
drivers/scsi/libsas/sas_scsi_host.c
include/scsi/libsas.h

index 81ce39d..2fc5a39 100644 (file)
@@ -184,7 +184,7 @@ static unsigned int sas_ata_qc_issue(struct ata_queued_cmd *qc)
        spin_unlock(ap->lock);
 
        /* If the device fell off, no sense in issuing commands */
-       if (dev->gone)
+       if (test_bit(SAS_DEV_GONE, &dev->state))
                goto out;
 
        task = sas_alloc_task(GFP_ATOMIC);
index 15d2239..f33d0c9 100644 (file)
@@ -1750,7 +1750,7 @@ static void sas_unregister_ex_tree(struct asd_sas_port *port, struct domain_devi
        struct domain_device *child, *n;
 
        list_for_each_entry_safe(child, n, &ex->children, siblings) {
-               child->gone = 1;
+               set_bit(SAS_DEV_GONE, &child->state);
                if (child->dev_type == EDGE_DEV ||
                    child->dev_type == FANOUT_DEV)
                        sas_unregister_ex_tree(port, child);
@@ -1771,7 +1771,7 @@ static void sas_unregister_devs_sas_addr(struct domain_device *parent,
                        &ex_dev->children, siblings) {
                        if (SAS_ADDR(child->sas_addr) ==
                            SAS_ADDR(phy->attached_sas_addr)) {
-                               child->gone = 1;
+                               set_bit(SAS_DEV_GONE, &child->state);
                                if (child->dev_type == EDGE_DEV ||
                                    child->dev_type == FANOUT_DEV)
                                        sas_unregister_ex_tree(parent->port, child);
@@ -1780,7 +1780,7 @@ static void sas_unregister_devs_sas_addr(struct domain_device *parent,
                                break;
                        }
                }
-               parent->gone = 1;
+               set_bit(SAS_DEV_GONE, &parent->state);
                sas_disable_routing(parent, phy->attached_sas_addr);
        }
        memset(phy->attached_sas_addr, 0, SAS_ADDR_SIZE);
index a47c7a7..d88e55f 100644 (file)
@@ -171,7 +171,7 @@ void sas_deform_port(struct asd_sas_phy *phy, int gone)
 
        if (port->num_phys == 1) {
                if (dev && gone)
-                       dev->gone = 1;
+                       set_bit(SAS_DEV_GONE, &dev->state);
                sas_unregister_domain_devices(port);
                sas_port_delete(port->port);
                port->port = NULL;
index fd60465..15533a1 100644 (file)
@@ -192,7 +192,7 @@ int sas_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
        int res = 0;
 
        /* If the device fell off, no sense in issuing commands */
-       if (dev->gone) {
+       if (test_bit(SAS_DEV_GONE, &dev->state)) {
                cmd->result = DID_BAD_TARGET << 16;
                goto out_done;
        }
index 42900fa..d792b13 100644 (file)
@@ -173,7 +173,10 @@ struct sata_device {
        struct ata_taskfile tf;
 };
 
-/* ---------- Domain device ---------- */
+enum {
+       SAS_DEV_GONE,
+};
+
 struct domain_device {
         enum sas_dev_type dev_type;
 
@@ -205,7 +208,7 @@ struct domain_device {
         };
 
         void *lldd_dev;
-       int gone;
+       unsigned long state;
        struct kref kref;
 };