sched: Convert the only user of cond_resched_bkl to use cond_resched()
Frederic Weisbecker [Thu, 16 Jul 2009 13:44:29 +0000 (15:44 +0200)]
fs/locks.c:flock_lock_file() is the only user of
cond_resched_bkl()

This helper doesn't do anything more than cond_resched(). The
latter naming is enough to explain that we are rescheduling if
needed.

The bkl suffix suggests another semantics but it's actually a
synonym of cond_resched().

Reported-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1247725694-6082-7-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

fs/locks.c
include/linux/sched.h

index b6440f5..2eb8197 100644 (file)
@@ -768,7 +768,7 @@ static int flock_lock_file(struct file *filp, struct file_lock *request)
         * give it the opportunity to lock the file.
         */
        if (found)
-               cond_resched_bkl();
+               cond_resched();
 
 find_conflict:
        for_each_lock(inode, before) {
index c41d424..cbbfca6 100644 (file)
@@ -2305,8 +2305,6 @@ extern int __cond_resched_softirq(void);
        __cond_resched_softirq();                               \
 })
 
-#define cond_resched_bkl()     cond_resched()
-
 /*
  * Does a critical section need to be broken due to another
  * task waiting?: (technically does not depend on CONFIG_PREEMPT,