dlm: Use cmwq for send and receive workqueues
Steven Whitehouse [Fri, 12 Nov 2010 12:12:29 +0000 (12:12 +0000)]
So far as I can tell, there is no reason to use a single-threaded
send workqueue for dlm, since it may need to send to several sockets
concurrently. Both workqueues are set to WQ_MEM_RECLAIM to avoid
any possible deadlocks, WQ_HIGHPRI since locking traffic is highly
latency sensitive (and to avoid a priority inversion wrt GFS2's
glock_workqueue) and WQ_FREEZABLE just in case someone needs to do
that (even though with current cluster infrastructure, it doesn't
make sense as the node will most likely land up ejected from the
cluster) in the future.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: David Teigland <teigland@redhat.com>

fs/dlm/lowcomms.c

index 77720f8..1d4e644 100644 (file)
@@ -1451,14 +1451,16 @@ static void work_stop(void)
 static int work_start(void)
 {
        int error;
-       recv_workqueue = create_workqueue("dlm_recv");
+       recv_workqueue = alloc_workqueue("dlm_recv", WQ_MEM_RECLAIM |
+                                        WQ_HIGHPRI | WQ_FREEZEABLE, 0);
        error = IS_ERR(recv_workqueue);
        if (error) {
                log_print("can't start dlm_recv %d", error);
                return error;
        }
 
-       send_workqueue = create_singlethread_workqueue("dlm_send");
+       send_workqueue = alloc_workqueue("dlm_send", WQ_MEM_RECLAIM |
+                                        WQ_HIGHPRI | WQ_FREEZEABLE, 0);
        error = IS_ERR(send_workqueue);
        if (error) {
                log_print("can't start dlm_send %d", error);