firewire: cdev: remove unneeded reference
Clemens Ladisch [Mon, 10 Jan 2011 16:29:03 +0000 (17:29 +0100)]
For outbound transactions, the IDR's and the callback's references now
have exactly the same lifetime, so we do not need both of them.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: "Stefan Richter" <stefanr@s5r6.in-berlin.de>

drivers/firewire/core-cdev.c

index 5485c08..e0c13fb 100644 (file)
@@ -562,8 +562,6 @@ static void complete_transaction(struct fw_card *card, int rcode,
 
        /* Drop the idr's reference */
        client_put(client);
-       /* Drop the transaction callback's reference */
-       client_put(client);
 }
 
 static int init_request(struct client *client,
@@ -601,9 +599,6 @@ static int init_request(struct client *client,
        if (ret < 0)
                goto failed;
 
-       /* Get a reference for the transaction callback */
-       client_get(client);
-
        fw_send_request(client->device->card, &e->r.transaction,
                        request->tcode, destination_id, request->generation,
                        speed, request->offset, e->response.data,