KVM: PPC E500: fix tlbcfg emulation
Liu Yu [Fri, 22 Jan 2010 11:36:53 +0000 (19:36 +0800)]
commit 55fb1027c1cf9797dbdeab48180da530e81b1c39 doesn't update tlbcfg correctly.
Fix it.

And since guest OS likes 'fixed' hardware,
initialize tlbcfg everytime when guest access is useless.
So move this part to init code.

Signed-off-by: Liu Yu <yu.liu@freescale.com>
Acked-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

arch/powerpc/include/asm/kvm_e500.h
arch/powerpc/kvm/e500_emulate.c
arch/powerpc/kvm/e500_tlb.c

index 569dfd3..7fea26f 100644 (file)
@@ -56,6 +56,8 @@ struct kvmppc_vcpu_e500 {
        u32 l1csr1;
        u32 hid0;
        u32 hid1;
+       u32 tlb0cfg;
+       u32 tlb1cfg;
 
        struct kvm_vcpu vcpu;
 };
index 95f8ec8..8e3edfb 100644 (file)
@@ -164,25 +164,9 @@ int kvmppc_core_emulate_mfspr(struct kvm_vcpu *vcpu, int sprn, int rt)
                kvmppc_set_gpr(vcpu, rt, vcpu_e500->mas7); break;
 
        case SPRN_TLB0CFG:
-       {
-               ulong tmp = SPRN_TLB0CFG;
-
-               tmp &= ~0xfffUL;
-               tmp |= vcpu_e500->guest_tlb_size[0];
-               kvmppc_set_gpr(vcpu, rt, tmp);
-               break;
-       }
-
+               kvmppc_set_gpr(vcpu, rt, vcpu_e500->tlb0cfg); break;
        case SPRN_TLB1CFG:
-       {
-               ulong tmp = SPRN_TLB1CFG;
-
-               tmp &= ~0xfffUL;
-               tmp |= vcpu_e500->guest_tlb_size[1];
-               kvmppc_set_gpr(vcpu, rt, tmp);
-               break;
-       }
-
+               kvmppc_set_gpr(vcpu, rt, vcpu_e500->tlb1cfg); break;
        case SPRN_L1CSR0:
                kvmppc_set_gpr(vcpu, rt, vcpu_e500->l1csr0); break;
        case SPRN_L1CSR1:
index 6a7fc01..0d772e6 100644 (file)
@@ -728,6 +728,12 @@ int kvmppc_e500_tlb_init(struct kvmppc_vcpu_e500 *vcpu_e500)
        if (vcpu_e500->shadow_pages[1] == NULL)
                goto err_out_page0;
 
+       /* Init TLB configuration register */
+       vcpu_e500->tlb0cfg = mfspr(SPRN_TLB0CFG) & ~0xfffUL;
+       vcpu_e500->tlb0cfg |= vcpu_e500->guest_tlb_size[0];
+       vcpu_e500->tlb1cfg = mfspr(SPRN_TLB1CFG) & ~0xfffUL;
+       vcpu_e500->tlb1cfg |= vcpu_e500->guest_tlb_size[1];
+
        return 0;
 
 err_out_page0: