[ALSA] Fix gus_pcm dereference before NULL
Eugene Teo [Fri, 17 Mar 2006 15:32:52 +0000 (16:32 +0100)]
Modules: GUS Library

The NULL check of substream is simply superfluous. It is
guaranteed to receive non-NULL substream. Thanks Takashi.

Coverity bug #861

Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

sound/isa/gus/gus_pcm.c

index d082939..c7f95e7 100644 (file)
@@ -114,8 +114,6 @@ static void snd_gf1_pcm_trigger_up(struct snd_pcm_substream *substream)
        unsigned char pan;
        unsigned int voice;
 
-       if (substream == NULL)
-               return;
        spin_lock_irqsave(&pcmp->lock, flags);
        if (pcmp->flags & SNDRV_GF1_PCM_PFLG_ACTIVE) {
                spin_unlock_irqrestore(&pcmp->lock, flags);