USB: pl2303: use tty_insert_flip_string_fixed_flag
Johan Hovold [Sat, 8 May 2010 13:18:41 +0000 (15:18 +0200)]
Use tty_insert_flip_string_fixed_flag to report errors to line
discipline.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

drivers/usb/serial/pl2303.c

index 18d1c44..6b60018 100644 (file)
@@ -786,12 +786,13 @@ static void pl2303_process_read_urb(struct urb *urb)
        if (line_status & UART_OVERRUN_ERROR)
                tty_insert_flip_char(tty, 0, TTY_OVERRUN);
 
-       if (tty_flag == TTY_NORMAL && !(port->port.console && port->sysrq))
-               tty_insert_flip_string(tty, data, urb->actual_length);
-       else {
+       if (port->port.console && port->sysrq) {
                for (i = 0; i < urb->actual_length; ++i)
                        if (!usb_serial_handle_sysrq_char(tty, port, data[i]))
                                tty_insert_flip_char(tty, data[i], tty_flag);
+       } else {
+               tty_insert_flip_string_fixed_flag(tty, data, tty_flag,
+                                                       urb->actual_length);
        }
 
        tty_flip_buffer_push(tty);