]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
IB/iser: Remove buggy back-pointer setting
authorOr Gerlitz <ogerlitz@voltaire.com>
Wed, 5 May 2010 14:30:34 +0000 (17:30 +0300)
committerRoland Dreier <rolandd@cisco.com>
Wed, 12 May 2010 16:30:44 +0000 (09:30 -0700)
The iscsi connection object life cycle includes binding and unbinding
(conn_stop) to/from the iscsi transport connection object.  Since
iscsi connection objects are recycled, at the time the transport
connection (e.g iser's IB connection) is released, it is not valid to
touch the iscsi connection tied to the transport back-pointer since it
may already point to a different transport connection.

Signed-off-by: Or Gerlitz <ogerlitz@voltaire.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/ulp/iser/iser_verbs.c

index b9d6aa102aa55b52b083fa2407fd91751c85bbdd..ed7c9013541285a3c24ec3bf3fae53098f9616f6 100644 (file)
@@ -346,8 +346,6 @@ static void iser_conn_release(struct iser_conn *ib_conn)
        /* on EVENT_ADDR_ERROR there's no device yet for this conn */
        if (device != NULL)
                iser_device_try_release(device);
-       if (ib_conn->iser_conn)
-               ib_conn->iser_conn->ib_conn = NULL;
        iscsi_destroy_endpoint(ib_conn->ep);
 }