tomoyo: fix memory leak in tomoyo_commit_ok()
Xiaochen Wang [Wed, 30 Mar 2011 15:27:32 +0000 (00:27 +0900)]
When memory used for policy exceeds the quota, tomoyo_memory_ok() return false.
In this case, tomoyo_commit_ok() must call kfree() before returning NULL.
This bug exists since 2.6.35.

Signed-off-by: Xiaochen Wang <wangxiaochen0@gmail.com>
Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: James Morris <jmorris@namei.org>

security/tomoyo/memory.c

index 2976126..42a7b1b 100644 (file)
@@ -75,6 +75,7 @@ void *tomoyo_commit_ok(void *data, const unsigned int size)
                memset(data, 0, size);
                return ptr;
        }
+       kfree(ptr);
        return NULL;
 }