dnotify: do not bother to lock entry->lock when reading mask
Eric Paris [Thu, 11 Jun 2009 15:09:47 +0000 (11:09 -0400)]
entry->lock is needed to make sure entry->mask does not change while
manipulating it.  In dnotify_should_send_event() we don't care if we get an
old or a new mask value out of this entry so there is no point it taking
the lock.

Signed-off-by: Eric Paris <eparis@redhat.com>

fs/notify/dnotify/dnotify.c

index 5134e89..ec459b6 100644 (file)
@@ -153,9 +153,8 @@ static bool dnotify_should_send_event(struct fsnotify_group *group,
        if (!entry)
                return false;
 
-       spin_lock(&entry->lock);
        send = (mask & entry->mask);
-       spin_unlock(&entry->lock);
+
        fsnotify_put_mark(entry); /* matches fsnotify_find_mark_entry */
 
        return send;