[PARISC] Fix double free when removing HIL drivers
Kyle McMartin [Thu, 30 Mar 2006 16:47:32 +0000 (11:47 -0500)]
On Thu, Mar 30, 2006 at 08:31:02AM -0500, Dmitry Torokhov wrote:
> Don't do that, its double free. input_unregister_device() normally
> causes release() to be called and free the device. input_free_device
> is only to be called when input_register_device has not been called or
> failed.
>
> Plus you might want to unregister device after closing serio port,
> otherwise your interrupt routine might be referencing already freed
> memory.

Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>

drivers/input/keyboard/hil_kbd.c
drivers/input/keyboard/hilkbd.c
drivers/input/mouse/hil_ptr.c

index 99f8c5b..63f387e 100644 (file)
@@ -240,9 +240,8 @@ static void hil_kbd_disconnect(struct serio *serio)
                return;
        }
 
-       input_unregister_device(kbd->dev);
        serio_close(serio);
-       input_free_device(kbd->dev);
+       input_unregister_device(kbd->dev);
        kfree(kbd);
 }
 
index 452c5f3..33edd03 100644 (file)
@@ -334,7 +334,6 @@ static void __exit hil_exit(void)
 
        input_unregister_device(hil_dev.dev);
 
-       input_free_device(hil_dev.dev);
        hil_dev.dev = NULL;
 
 #if defined(CONFIG_PARISC)
index a648f9f..bfb564f 100644 (file)
@@ -233,9 +233,8 @@ static void hil_ptr_disconnect(struct serio *serio)
                return;
        }
 
-       input_unregister_device(ptr->dev);
        serio_close(serio);
-       input_free_device(ptr->dev);
+       input_unregister_device(ptr->dev);
        kfree(ptr);
 }