perf top: Use a macro instead of a constant variable
Arnaldo Carvalho de Melo [Mon, 22 Feb 2010 19:14:22 +0000 (16:14 -0300)]
To overcome a silly gcc warning:

 cc1: warnings being treated as errors
 builtin-top.c: In function ‘lookup_sym_source’:
 builtin-top.c:291: warning: not protecting local variables:
 variable length buffer make: *** [builtin-top.o] Error 1
 make: *** Waiting for unfinished jobs....

That is emitted for this:

const size_t pattern_len = BITS_PER_LONG / 4 + 2;
char pattern[pattern_len + 1];

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1266866062-6287-1-git-send-email-acme@infradead.org>
[ -v2: macroify the naming style ]
Signed-off-by: Ingo Molnar <mingo@elte.hu>

tools/perf/builtin-top.c

index c72ab50..c670698 100644 (file)
@@ -287,19 +287,20 @@ out_unlock:
        pthread_mutex_unlock(&syme->src->lock);
 }
 
+#define PATTERN_LEN            (BITS_PER_LONG / 4 + 2)
+
 static void lookup_sym_source(struct sym_entry *syme)
 {
        struct symbol *symbol = sym_entry__symbol(syme);
        struct source_line *line;
-       const size_t pattern_len = BITS_PER_LONG / 4 + 2;
-       char pattern[pattern_len + 1];
+       char pattern[PATTERN_LEN + 1];
 
        sprintf(pattern, "%0*Lx <", BITS_PER_LONG / 4,
                map__rip_2objdump(syme->map, symbol->start));
 
        pthread_mutex_lock(&syme->src->lock);
        for (line = syme->src->lines; line; line = line->next) {
-               if (memcmp(line->line, pattern, pattern_len) == 0) {
+               if (memcmp(line->line, pattern, PATTERN_LEN) == 0) {
                        syme->src->source = line;
                        break;
                }