hwspinlock/core/omap: fix id issues on multiple hwspinlock devices
Ohad Ben-Cohen [Mon, 5 Sep 2011 20:15:06 +0000 (23:15 +0300)]
hwspinlock devices provide system-wide hardware locks that are used
by remote processors that have no other way to achieve synchronization.

To achieve that, each physical lock must have a system-wide id number
that is agreed upon, otherwise remote processors can't possibly assume
they're using the same hardware lock.

Usually boards have a single hwspinlock device, which provides several
hwspinlocks, and in this case, they can be trivially numbered 0 to
(num-of-locks - 1).

In case boards have several hwspinlocks devices, a different base id
should be used for each hwspinlock device (they can't all use 0 as
a starting id!).

While this is certainly not common, it's just plain wrong to just
silently use 0 as a base id whenever the hwspinlock driver is probed.

This patch provides a hwspinlock_pdata structure, that boards can use
to set a different base id for each of the hwspinlock devices they may
have, and demonstrates how to use it with the omap hwspinlock driver.

While we're at it, make sure the hwspinlock core prints an explicit
error message in case an hwspinlock is registered with an id number
that already exists; this will help users catch such base id issues.

Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
Acked-by: Tony Lindgren <tony@atomide.com>

arch/arm/mach-omap2/hwspinlock.c
drivers/hwspinlock/hwspinlock_core.c
drivers/hwspinlock/omap_hwspinlock.c
include/linux/hwspinlock.h

index 06d4a80..eb7e509 100644 (file)
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/err.h>
+#include <linux/hwspinlock.h>
 
 #include <plat/omap_hwmod.h>
 #include <plat/omap_device.h>
 
+static struct hwspinlock_pdata omap_hwspinlock_pdata __initdata = {
+       .base_id = 0,
+};
+
 struct omap_device_pm_latency omap_spinlock_latency[] = {
        {
                .deactivate_func = omap_device_idle_hwmods,
@@ -48,7 +53,8 @@ int __init hwspinlocks_init(void)
        if (oh == NULL)
                return -EINVAL;
 
-       od = omap_device_build(dev_name, 0, oh, NULL, 0,
+       od = omap_device_build(dev_name, 0, oh, &omap_hwspinlock_pdata,
+                               sizeof(struct hwspinlock_pdata),
                                omap_spinlock_latency,
                                ARRAY_SIZE(omap_spinlock_latency), false);
        if (IS_ERR(od)) {
index af5175c..4eb85b4 100644 (file)
@@ -282,6 +282,8 @@ int hwspin_lock_register(struct hwspinlock *hwlock)
        spin_lock(&hwspinlock_tree_lock);
 
        ret = radix_tree_insert(&hwspinlock_tree, hwlock->id, hwlock);
+       if (ret == -EEXIST)
+               pr_err("hwspinlock id %d already exists!\n", hwlock->id);
        if (ret)
                goto out;
 
index d058348..2044d18 100644 (file)
@@ -94,12 +94,16 @@ static const struct hwspinlock_ops omap_hwspinlock_ops = {
 
 static int __devinit omap_hwspinlock_probe(struct platform_device *pdev)
 {
+       struct hwspinlock_pdata *pdata = pdev->dev.platform_data;
        struct omap_hwspinlock *omap_lock;
        struct omap_hwspinlock_state *state;
        struct resource *res;
        void __iomem *io_base;
        int i, ret;
 
+       if (!pdata)
+               return -ENODEV;
+
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        if (!res)
                return -ENODEV;
@@ -141,7 +145,7 @@ static int __devinit omap_hwspinlock_probe(struct platform_device *pdev)
                omap_lock = &state->lock[i];
 
                omap_lock->lock.dev = &pdev->dev;
-               omap_lock->lock.id = i;
+               omap_lock->lock.id = pdata->base_id + i;
                omap_lock->lock.ops = &omap_hwspinlock_ops;
                omap_lock->addr = io_base + LOCK_BASE_OFFSET + sizeof(u32) * i;
 
index 8390efc..f85cef5 100644 (file)
 
 struct hwspinlock;
 
+/**
+ * struct hwspinlock_pdata - platform data for hwspinlock drivers
+ * @base_id: base id for this hwspinlock device
+ *
+ * hwspinlock devices provide system-wide hardware locks that are used
+ * by remote processors that have no other way to achieve synchronization.
+ *
+ * To achieve that, each physical lock must have a system-wide id number
+ * that is agreed upon, otherwise remote processors can't possibly assume
+ * they're using the same hardware lock.
+ *
+ * Usually boards have a single hwspinlock device, which provides several
+ * hwspinlocks, and in this case, they can be trivially numbered 0 to
+ * (num-of-locks - 1).
+ *
+ * In case boards have several hwspinlocks devices, a different base id
+ * should be used for each hwspinlock device (they can't all use 0 as
+ * a starting id!).
+ *
+ * This platform data structure should be used to provide the base id
+ * for each device (which is trivially 0 when only a single hwspinlock
+ * device exists). It can be shared between different platforms, hence
+ * its location.
+ */
+struct hwspinlock_pdata {
+       int base_id;
+};
+
 #if defined(CONFIG_HWSPINLOCK) || defined(CONFIG_HWSPINLOCK_MODULE)
 
 int hwspin_lock_register(struct hwspinlock *lock);