perf top browser: Fix up exit keys
Arnaldo Carvalho de Melo [Fri, 25 Feb 2011 12:30:29 +0000 (09:30 -0300)]
The left key was exiting 'perf top --tui' when it really shouldn't, it
was too easy to leave the live annotation window and then press one too
many <- and get out of the tool altogether.

Do just like the report TUI does, ignore the left key for exit and also
ask the user when pressing ESC if that is really what is wanted.

Reported-by: Mike Galbraith <>
Suggested-by: Ingo Molnar <>
Cc: Frederic Weisbecker <>
Cc: Ingo Molnar <>
Cc: Mike Galbraith <>
Cc: Paul Mackerras <>
Cc: Peter Zijlstra <>
Cc: Stephane Eranian <>
Cc: Tom Zanussi <>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <>


index 2f47224..e9381ec 100644 (file)
@@ -10,6 +10,7 @@
 #include "../../annotate.h"
 #include "../helpline.h"
 #include "../libslang.h"
+#include "../util.h"
 #include "../../evlist.h"
 #include "../../hist.h"
 #include "../../sort.h"
@@ -174,6 +175,12 @@ static int perf_top_browser__run(struct perf_top_browser *browser)
                        if (browser->selection)
+               case NEWT_KEY_LEFT:
+                       continue;
+               case NEWT_KEY_ESCAPE:
+                       if (!ui__dialog_yesno("Do you really want to exit?"))
+                               continue;
+                       /* Fall thru */
                        goto out;