target: remove the TRANSPORT_REMOVE state
Christoph Hellwig [Mon, 17 Oct 2011 17:56:50 +0000 (13:56 -0400)]
We never queue an command with this state, and only set it in a completely
bogus place in tcm_fc.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

drivers/target/target_core_transport.c
drivers/target/tcm_fc/tfc_cmd.c
include/target/target_core_base.h

index 53d332c..0d055f0 100644 (file)
@@ -4787,9 +4787,6 @@ get_cmd:
                case TRANSPORT_COMPLETE_OK:
                        transport_generic_complete_ok(cmd);
                        break;
-               case TRANSPORT_REMOVE:
-                       transport_put_cmd(cmd);
-                       break;
                case TRANSPORT_FREE_CMD_INTR:
                        transport_generic_free_cmd(cmd, 0);
                        break;
index 55a278e..6195026 100644 (file)
@@ -267,7 +267,6 @@ static void ft_recv_seq(struct fc_seq *sp, struct fc_frame *fp, void *arg)
 
        if (IS_ERR(fp)) {
                /* XXX need to find cmd if queued */
-               cmd->se_cmd.t_state = TRANSPORT_REMOVE;
                cmd->seq = NULL;
                transport_generic_free_cmd(&cmd->se_cmd, 0);
                return;
index 0271936..ced065c 100644 (file)
@@ -95,7 +95,6 @@ enum transport_state_table {
        TRANSPORT_ISTATE_PROCESSING = 11,
        TRANSPORT_ISTATE_PROCESSED = 12,
        TRANSPORT_KILL          = 13,
-       TRANSPORT_REMOVE        = 14,
        TRANSPORT_FREE          = 15,
        TRANSPORT_NEW_CMD_MAP   = 16,
        TRANSPORT_FREE_CMD_INTR = 17,