integrity: ima iint radix_tree_lookup locking fix
Mimi Zohar [Fri, 20 Feb 2009 22:28:29 +0000 (14:28 -0800)]
Based on Andrew Morton's comments:
- add missing locks around radix_tree_lookup in ima_iint_insert()

Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
Cc: James Morris <jmorris@namei.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Morris <jmorris@namei.org>

security/integrity/ima/ima_iint.c

index 1f035e8..ec79f1e 100644 (file)
@@ -73,8 +73,10 @@ out:
        if (rc < 0) {
                kmem_cache_free(iint_cache, iint);
                if (rc == -EEXIST) {
+                       spin_lock(&ima_iint_lock);
                        iint = radix_tree_lookup(&ima_iint_store,
                                                 (unsigned long)inode);
+                       spin_unlock(&ima_iint_lock);
                } else
                        iint = NULL;
        }