ASoC: jack: Fix race in snd_soc_jack_add_gpios
Lars-Peter Clausen [Fri, 31 Jul 2009 19:15:25 +0000 (21:15 +0200)]
The irq can fire as soon as it has been requested, thus all fields accessed
from within the irq handler must be initialized prior to requesting the irq.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

sound/soc/soc-jack.c

index 4aa7d8f..1d455ab 100644 (file)
@@ -221,6 +221,9 @@ int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count,
                if (ret)
                        goto err;
 
+               INIT_WORK(&gpios[i].work, gpio_work);
+               gpios[i].jack = jack;
+
                ret = request_irq(gpio_to_irq(gpios[i].gpio),
                                gpio_handler,
                                IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
@@ -234,9 +237,6 @@ int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count,
                gpio_export(gpios[i].gpio, false);
 #endif
 
-               INIT_WORK(&gpios[i].work, gpio_work);
-               gpios[i].jack = jack;
-
                /* Update initial jack status */
                snd_soc_jack_gpio_detect(&gpios[i]);
        }