ACPI: Register EC io ports in /proc/ioports
Thomas Renninger [Fri, 16 Jul 2010 11:11:33 +0000 (13:11 +0200)]
Formerly these have been exposed through /proc/..
Better register them where all IO ports should get registered
and scream loud if someone else claims to use them.

EC data and command port typically should show up like this
then:
...
  0060-0060 : keyboard
  0062-0062 : EC data
  0064-0064 : keyboard
  0066-0066 : EC command
  0070-0071 : rtc0
...

Signed-off-by: Thomas Renninger <trenn@suse.de>

CC: Alexey Starikovskiy <astarikovskiy@suse.de>
CC: Len Brown <lenb@kernel.org>
CC: linux-kernel@vger.kernel.org
CC: linux-acpi@vger.kernel.org
CC: Bjorn Helgaas <bjorn.helgaas@hp.com>
CC: platform-driver-x86@vger.kernel.org
Signed-off-by: Matthew Garrett <mjg@redhat.com>

drivers/acpi/ec.c

index a79e1b1..265a99c 100644 (file)
@@ -864,10 +864,18 @@ ec_parse_io_ports(struct acpi_resource *resource, void *context)
         * the second address region returned is the status/command
         * port.
         */
-       if (ec->data_addr == 0)
+       if (ec->data_addr == 0) {
                ec->data_addr = resource->data.io.minimum;
-       else if (ec->command_addr == 0)
+               WARN(!request_region(ec->data_addr, 1, "EC data"),
+                    "Could not request EC data io port %lu",
+                    ec->data_addr);
+       }
+       else if (ec->command_addr == 0) {
                ec->command_addr = resource->data.io.minimum;
+               WARN(!request_region(ec->command_addr, 1, "EC command"),
+                    "Could not request EC command io port %lu",
+                    ec->command_addr);
+       }
        else
                return AE_CTRL_TERMINATE;